From: Marlon Richert <marlon.richert@gmail.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Does add-zle-hook-widget violate the contract of ZLE hook widgets?
Date: Wed, 23 Jun 2021 23:30:55 +0300 [thread overview]
Message-ID: <CAHLkEDuCGVH9s62b9oPK7Up9MnjR1Yx6WbSggxLDR_AtKhrA8g@mail.gmail.com> (raw)
% foo() { [[ -n $foo ]] && print foo }
% zle -N zle-line-init foo
% autoload -Uz add-zle-hook-widget
% bar() { print bar }
% add-zle-hook-widget line-init bar
%
foo implements a perfectly fine zle-line-init widget. It obeys the
contract laid out at
https://zsh.sourceforge.io/Doc/Release/Zsh-Line-Editor.html#Special-Widgets,
which says nothing about return values. There are plenty of such
zle-xxx widgets out there in the wild, written before the introduction
of add-zle-hook-widget.
bar is also a perfectly fine hook function, implementing the contract
laid out by add-zle-hook-widget.
However, through no fault of its own, bar will never get called,
because once foo has return non-zero, azsh:zle-line-init will not call
any further hook widgets:
function azhw:${^hooktypes} {
local -a hook_widgets
local hook
# Values of these styles look like number:name
# and we run them in number order
zstyle -a $WIDGET widgets hook_widgets
for hook in "${(@)${(@on)hook_widgets[@]}#<->:}"; do
if [[ "$hook" = user:* ]]; then
# Preserve $WIDGET within the renamed widget
zle "$hook" -f "nolast" -N -- "$@"
else
zle "$hook" -f "nolast" -Nw -- "$@"
fi || return # <-- This is the offending line.
done
return 0
}
(Comment mine.)
Isn't add-zle-hook-widget here violating the contract between foo and
zle -N zle-line-init? Should that `|| return` be removed?
next reply other threads:[~2021-06-23 20:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 20:30 Marlon Richert [this message]
2021-06-23 21:57 ` Daniel Shahaf
2021-06-23 23:33 ` Lawrence Velázquez
2021-06-24 0:09 ` Daniel Shahaf
2021-06-24 10:34 ` Marlon Richert
2021-06-24 10:45 ` Roman Perepelitsa
2021-06-24 18:54 ` Daniel Shahaf
2021-06-24 19:51 ` Roman Perepelitsa
2021-06-24 18:30 ` Daniel Shahaf
2021-06-24 21:48 ` Marlon Richert
2021-06-24 22:29 ` Lawrence Velázquez
2021-06-26 10:12 ` Marlon Richert
2021-06-26 14:51 ` Bart Schaefer
2021-06-24 23:52 ` Daniel Shahaf
2021-06-26 10:49 ` Marlon Richert
2021-06-25 17:34 ` Bart Schaefer
2021-06-27 8:19 Marlon Richert
2021-06-29 2:06 ` Bart Schaefer
2021-06-29 14:50 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLkEDuCGVH9s62b9oPK7Up9MnjR1Yx6WbSggxLDR_AtKhrA8g@mail.gmail.com \
--to=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).