From: Bart Schaefer <schaefer@brasslantern.com>
To: Philippe Altherr <philippe.altherr@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Remove NOERREXIT_UNTIL_EXEC
Date: Sat, 3 Dec 2022 21:28:54 -0800 [thread overview]
Message-ID: <CAH+w=7ZYFKpaFv8d05L6O7vcAc6HfQ5ye8xGgV_Mqz217eCong@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchsuZ7A+RYxrfSBsF0boZhd2ANYe85iVwg2XzUBEWg7NLg@mail.gmail.com>
On Fri, Dec 2, 2022 at 4:31 PM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
> The noerrexit NOERREXIT_UNTIL_EXEC bit is never set and can therefore be removed. In other words the patch only removes dead code.
That explains MY confusion over the meaning of NOERREXIT_UNTIL_EXEC
when you first asked about it: The use for which it was originally
intended had gone away.
> One thing that distinguishes the NOERREXIT_UNTIL_EXEC bit from the other noerrexit bits is that it seems intended for the caller(s) of the function that sets it, while the other bits are intended for the callee(s). This is similar to today's this_noerrexit variable.
Moot point now, but I believe it was still intended for the callees --
the original bug being fixed involved error state propagating down
into for/select loops.
> QUESTION: Should NOERREXIT_SIGNAL's value be changed to 4 (from 8) since the value 4 is no longer used by NOERREXIT_UNTIL_EXEC?
I don't think that's necessary.
prev parent reply other threads:[~2022-12-04 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 0:31 Philippe Altherr
2022-12-03 0:34 ` Philippe Altherr
2022-12-04 5:28 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZYFKpaFv8d05L6O7vcAc6HfQ5ye8xGgV_Mqz217eCong@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).