From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Crash on jobstates since workers/49783 (commit 6a8aa2a)
Date: Mon, 28 Mar 2022 09:44:10 -0700 [thread overview]
Message-ID: <CAH+w=7Zbp2DYnmfseS=6zvkh6Raa036HntbqTrOdRNL5391vJQ@mail.gmail.com> (raw)
In-Reply-To: <1830314137.713553.1648484054367@mail2.virginmedia.com>
On Mon, Mar 28, 2022 at 9:14 AM Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
>
> We have two options here: either keep jobstates for top level jobs
> and introduce a separate one for the last thing started in the current
> shell, or decide on the fly that we're no longer interested in the
> parent shell.
It's not just "the last thing started" that's wanted, it's a list of
every process that was started. So although it's a bit magical that
backgrounding a job clears the job table, that seems the better of
those two alternatives.
Another possibility that occurs to me is for the values in $jobstates to change.
... The keys are the job numbers and the values
are strings of the form 'JOB-STATE:MARK:PID=STATE...'. The
JOB-STATE gives the state the whole job is currently in, one of
'running', 'suspended', or 'done'.
What if JOB-STATE became "parent" in the subshell? Or something along
those lines. I guess that goes back to having to make a deep copy of
the saved job structure.
Incidentally:
% sleep 10 & print -aC2 ${(kv)jobstates}; (jobs -l; print -aC2 ${(kv)jobstates})
[1] 69151
1 running:+:69151=running
[1] + 69151 running sleep 10
1 running:+
How is it that "jobs -l" still knows the PID from the parent job, but
$jobstates cannot report it?
next prev parent reply other threads:[~2022-03-28 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 22:32 Bart Schaefer
2022-03-27 5:34 ` Bart Schaefer
2022-03-28 8:47 ` Peter Stephenson
2022-03-28 14:49 ` Peter Stephenson
2022-03-28 15:09 ` Bart Schaefer
2022-03-28 16:14 ` Peter Stephenson
2022-03-28 16:44 ` Bart Schaefer [this message]
2022-03-28 19:52 ` Peter Stephenson
2022-03-29 3:49 ` Bart Schaefer
2022-03-29 9:08 ` Peter Stephenson
2022-03-29 13:31 ` Peter Stephenson
2022-03-29 15:39 ` Bart Schaefer
2022-03-29 15:36 ` Bart Schaefer
2022-03-29 15:41 ` Peter Stephenson
2022-03-28 15:13 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Zbp2DYnmfseS=6zvkh6Raa036HntbqTrOdRNL5391vJQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).