help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Crash on jobstates since workers/49783 (commit 6a8aa2a)
Date: Mon, 28 Mar 2022 08:09:37 -0700	[thread overview]
Message-ID: <CAH+w=7bYY+nwKeaDWdFh9x+zJ79EyqyOkeQJ7nBOE39O_5HzAw@mail.gmail.com> (raw)
In-Reply-To: <1613542531.711035.1648478945973@mail2.virginmedia.com>

On Mon, Mar 28, 2022 at 7:49 AM Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
> Just thinking the pukka way to do this is actually zero the PN fields
> in the saved job structure when we enter the subshell (unless we decide
> to preserve them properly, which is more work but should be possible).

Looking at the way zargs was using subshells and $jobstates, I think
it's important that there be some way to distinguish jobs that the
subshell can't manage.

% % sleep 5 & ( sleep 2 & print -aC2 ${(kv)jobstates} )
[1] 68859
1  running:+
3  running:

How is it helpful that this returned anything?  Previously the
subshell could get information about the jobs it started itself, but
now it gets nothing.  I'm not even sure what job 3 is, there, as it
only shows up in the table at all a small fraction of the time when I
try this (usually it's just job 1).

  reply	other threads:[~2022-03-28 15:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 22:32 Bart Schaefer
2022-03-27  5:34 ` Bart Schaefer
2022-03-28  8:47   ` Peter Stephenson
2022-03-28 14:49     ` Peter Stephenson
2022-03-28 15:09       ` Bart Schaefer [this message]
2022-03-28 16:14         ` Peter Stephenson
2022-03-28 16:44           ` Bart Schaefer
2022-03-28 19:52             ` Peter Stephenson
2022-03-29  3:49               ` Bart Schaefer
2022-03-29  9:08                 ` Peter Stephenson
2022-03-29 13:31                   ` Peter Stephenson
2022-03-29 15:39                     ` Bart Schaefer
2022-03-29 15:36                   ` Bart Schaefer
2022-03-29 15:41                     ` Peter Stephenson
2022-03-28 15:13     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7bYY+nwKeaDWdFh9x+zJ79EyqyOkeQJ7nBOE39O_5HzAw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).