From: Bart Schaefer <schaefer@brasslantern.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [RFC] Looking for opinions on accepting refactoring patches
Date: Sat, 17 Mar 2018 16:39:08 -0700 [thread overview]
Message-ID: <CAH+w=7Zy1GHmZYOzOOW7mbMnVhcpNzC=ttgu6ib=zZae6UGSnQ@mail.gmail.com> (raw)
In-Reply-To: <20180317231715.dc5zcswwoe5vf2zx@gmail.com>
To what Oliver said, I would just add: I'm much happier accepting
patches that stay somewhat close to the code formatting style that's
already in use, which is pretty lax in general but boils down to:
- don't use // comment to end of line
- don't use CamelCaps except for typedef names
- indent 4 spaces with 8-space tab stops if you use tabs at all
- stick to 80 columns where possible (yes, we're old fogeys)
- use whitespace after keywords and commas and around open/close
braces, but not after open or before close parens and brackets
- violate that latter for readability, especially with extra line breaks
next prev parent reply other threads:[~2018-03-17 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 20:39 Joey Pabalinas
2018-03-17 11:27 ` Oliver Kiddle
2018-03-17 23:17 ` Joey Pabalinas
2018-03-17 23:39 ` Bart Schaefer [this message]
2018-03-18 1:48 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Zy1GHmZYOzOOW7mbMnVhcpNzC=ttgu6ib=zZae6UGSnQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).