From: Bart Schaefer <schaefer@brasslantern.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Cc: Peiyuan Song <squallatf@gmail.com>
Subject: Re: [PATCH v2] Make zpty module work in the cygwin and msys2
Date: Sat, 16 Jan 2021 10:34:31 -0800 [thread overview]
Message-ID: <CAH+w=7aAYKWc80GKC_cwuZJFgY-aeD1TXHGgekMagmYX_sw75g@mail.gmail.com> (raw)
In-Reply-To: <CAE0YKFuSTc1Rt4c4ySAMfWPmb0hu6tFNd0ScHrOgAHUtvxyT9g@mail.gmail.com>
On Thu, Jan 14, 2021 at 8:30 PM Peiyuan Song <squallatf@gmail.com> wrote:
>
> v2 change: make fdtable[master]
I don't see anything technically wrong with this, but it does
duplicate the code for check_fd_table.
Anyone else have thoughts? Can someone else who compiles on cygwin
give this a once-over?
next prev parent reply other threads:[~2021-01-16 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 4:29 Peiyuan Song
2021-01-16 18:34 ` Bart Schaefer [this message]
2021-01-19 1:52 ` Peiyuan Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7aAYKWc80GKC_cwuZJFgY-aeD1TXHGgekMagmYX_sw75g@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=squallatf@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).