Segfault copying an emulated function outside of emulation

Segfault copying an emulated function outside of emulation

[Matthew Martin]

ahmubashshir on IRC reported the following causes zsh to segfault

    zsh -c 'emulate sh -c "foo(){ :; }"; functions -c foo bar'

This seems to be because bin_functions calls sticky_emulation_dup with
sticky which is NULL outside of emulation. The below patch fixes the
segfault, but I can't claim to be terribly familiar with the code.


diff --git a/Src/builtin.c b/Src/builtin.c
index 1cef7cce8..4a220ccd7 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3304,7 +3304,7 @@ bin_functions(char *name, char **argv, Options ops, int func)
 	if (newsh->redir)
 	    newsh->redir->nref++;
 	if (shf->sticky)
-	    newsh->sticky = sticky_emulation_dup(sticky, 0);
+	    newsh->sticky = sticky_emulation_dup(shf->sticky, 0);
 	shfunctab->addnode(shfunctab, ztrdup(argv[1]), &newsh->node);
 	return 0;
     }

Re: Segfault copying an emulated function outside of emulation

[Bart Schaefer]

On Thu, Jun 9, 2022 at 10:30 AM Matthew Martin <phy1729@gmail.com> wrote:
>
> ahmubashshir on IRC reported the following causes zsh to segfault

This looks right to me, so I've merged this with my patch from 50351
and will commit both.