[PATCH] More typeset -p troubles

[PATCH] More typeset -p troubles

[Bart Schaefer]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

The "-m pattern" option is supposed to enable printing namespaces, but
that didn't work when combined with -p.

The -p option could also cause an unset parameter to become set if a
named reference pointed at it.

Noticed but NOT fixed here:  The "-p 1" option (add newlines within
array assignment output) does not work when combined with "-m".

[-- Attachment #2: more-typeset-p.txt --]
[-- Type: text/plain, Size: 1109 bytes --]

diff --git a/Src/builtin.c b/Src/builtin.c
index d99802f5f..f38a54936 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -2236,12 +2236,12 @@ typeset_single(char *cname, char *pname, Param pm, int func,
 	}
 	on &= ~PM_LOCAL;
 	if (!on && !roff && !ASG_VALUEP(asg)) {
+	    int with_ns = OPT_ISSET(ops,'m') ? PRINT_WITH_NAMESPACE : 0;
 	    if (OPT_ISSET(ops,'p'))
-		paramtab->printnode(&pm->node, PRINT_TYPESET);
+		paramtab->printnode(&pm->node, PRINT_TYPESET|with_ns);
 	    else if (!OPT_ISSET(ops,'g') &&
 		     (unset(TYPESETSILENT) || OPT_ISSET(ops,'m')))
-		paramtab->printnode(&pm->node,
-				    PRINT_INCLUDEVALUE|PRINT_WITH_NAMESPACE);
+		paramtab->printnode(&pm->node, PRINT_INCLUDEVALUE|with_ns);
 	    return pm;
 	}
 	if ((pm->node.flags & PM_RESTRICTED) && isset(RESTRICTED)) {
@@ -2502,6 +2502,8 @@ typeset_single(char *cname, char *pname, Param pm, int func,
 		    "%s: inconsistent array element or slice assignment", pname);
 	    return NULL;
 	}
+    } else if (!pm && OPT_ISSET(ops,'p')) {
+	return NULL;
     }
     /*
      * As we can hide existing parameters, we allow a name if