From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Up-scope named references, vs. ksh
Date: Fri, 1 Mar 2024 15:28:58 -0800 [thread overview]
Message-ID: <CAH+w=7bVzYFBsqpZy40GEJ6qGpM+BQz9AbY=3eTtW_2B4wB3dA@mail.gmail.com> (raw)
In-Reply-To: <20240301182238.tpyajwblbam5bxw7@chazelas.org>
On Fri, Mar 1, 2024 at 10:22 AM Stephane Chazelas <stephane@chazelas.org> wrote:
>
> $ ./Src/zsh -c 'f() { typeset -n ref=$1; unset ref; local var=2; ref=3; }; typeset -A var; f var; echo $var'
> <empty>
That's an actual bug, regardless of the rest of this discussion.
diff --git a/Src/builtin.c b/Src/builtin.c
index 44dfed651..83144677b 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3932,8 +3932,14 @@ bin_unset(char *name, char **argv, Options ops, int func)
}
} else {
if (!OPT_ISSET(ops,'n')) {
+ int ref = (pm->node.flags & PM_NAMEREF);
if (!(pm = (Param)resolve_nameref(pm, NULL)))
continue;
+ if (ref && pm->level < locallevel) {
+ /* Just mark unset, do not remove from table */
+ pm->node.flags |= PM_DECLARED|PM_UNSET;
+ continue;
+ }
}
if (unsetparam_pm(pm, 0, 1))
returnval = 1;
next prev parent reply other threads:[~2024-03-01 23:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 2:21 [PATCH 1/3]: Add named references Bart Schaefer
2023-02-08 3:45 ` Oliver Kiddle
2023-02-08 4:59 ` Bart Schaefer
2023-02-08 23:16 ` Bart Schaefer
2023-02-09 0:47 ` Oliver Kiddle
2023-02-09 2:01 ` Oliver Kiddle
2023-02-09 5:45 ` Bart Schaefer
2023-02-09 4:49 ` Bart Schaefer
2023-02-09 20:49 ` Oliver Kiddle
2023-02-09 23:07 ` Bart Schaefer
2023-02-11 3:04 ` Bart Schaefer
2023-02-11 3:55 ` Bart Schaefer
2023-02-11 5:36 ` Speaking of dangerous referents Bart Schaefer
2023-02-12 8:00 ` Oliver Kiddle
2023-02-12 8:34 ` Bart Schaefer
2023-02-11 7:02 ` [PATCH 1/3]: Add named references Oliver Kiddle
2023-02-11 7:45 ` Bart Schaefer
2023-02-11 23:43 ` Bart Schaefer
2023-02-11 23:45 ` Bart Schaefer
2023-02-12 7:38 ` Oliver Kiddle
2024-02-11 7:00 ` Stephane Chazelas
2024-02-11 16:14 ` Bart Schaefer
2024-02-11 16:42 ` Bart Schaefer
2024-02-18 3:26 ` Up-scope named references, vs. ksh Bart Schaefer
2024-02-20 21:05 ` Stephane Chazelas
2024-02-20 22:30 ` Bart Schaefer
2024-02-21 20:12 ` Stephane Chazelas
2024-02-29 5:16 ` Bart Schaefer
2024-03-01 18:22 ` Stephane Chazelas
2024-03-01 20:34 ` Bart Schaefer
2024-03-02 7:29 ` Bart Schaefer
2024-03-02 23:55 ` [PATCH] "typeset -nu" (was Re: Up-scope named references, vs. ksh) Bart Schaefer
2024-03-01 23:28 ` Bart Schaefer [this message]
2024-03-03 13:44 ` Up-scope named references, vs. ksh Stephane Chazelas
2024-03-03 19:04 ` Bart Schaefer
2024-03-03 20:27 ` Stephane Chazelas
2024-03-03 22:58 ` Bart Schaefer
2024-03-04 19:59 ` Stephane Chazelas
2024-03-05 1:05 ` Oliver Kiddle
2024-03-05 2:53 ` Bart Schaefer
2024-03-05 5:43 ` Mikael Magnusson
2024-03-05 6:30 ` Stephane Chazelas
2024-03-06 5:04 ` [PATCH] local vs. nameref scoping (was Re: Up-scope named references, vs. ksh) Bart Schaefer
2023-02-12 9:02 ` [PATCH 1/3]: Add named references Oliver Kiddle
2023-02-12 18:59 ` Bart Schaefer
2023-02-12 19:45 ` PM_* flags in zsh.h (was Re: [PATCH 1/3]: Add named references) Bart Schaefer
2023-02-12 21:01 ` Oliver Kiddle
2023-02-12 22:54 ` [PATCH 1/3]: Add named references Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bVzYFBsqpZy40GEJ6qGpM+BQz9AbY=3eTtW_2B4wB3dA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).