From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match
Date: Thu, 13 Aug 2015 00:34:05 +0200 [thread overview]
Message-ID: <CAHYJk3Rp2+h-ztEkoJcn=8b0tNt7EMiDQd17pHoSr+ckYSuLrA@mail.gmail.com> (raw)
In-Reply-To: <150812144433.ZM14263@torch.brasslantern.com>
On Wed, Aug 12, 2015 at 11:44 PM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On Aug 12, 11:15pm, Mikael Magnusson wrote:
> }
> } Well, I made the change locally and the tag in completions of files to
> } rmdir changed from all-files to other-files.
>
> Sure, but the question is how likely is it that someone has a style
> that relies on that tag name?
>
> Also you can force it back to all-files with the file-patterns style,
> so there'd have to be a case where the user has list-dirs-first, does
> not have file-patterns, and looks for all-files as a tag context.
So I guess the uncontroversial thing to do is to just add the
other-files in the fallback case, and leave the middle one alone as
all-files then? I don't see why "my" fallback should be other-files
while the existing fallback is all-files, but I don't care either way,
I just want the files to be completed at all :).
--
Mikael Magnusson
next prev parent reply other threads:[~2015-08-12 22:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 3:04 PATCH 1/5: _git: various fixes Mikael Magnusson
2015-08-12 3:05 ` PATCH 2/5: _wget: complete headers for --header and add --no-use-server-timestamps Mikael Magnusson
2015-08-12 3:05 ` PATCH 3/5: _imagemagick: complete all files if image files didn't match Mikael Magnusson
2015-08-12 17:20 ` Oliver Kiddle
2015-08-12 18:12 ` Mikael Magnusson
2015-08-12 18:59 ` Bart Schaefer
2015-08-12 19:35 ` Mikael Magnusson
2015-08-12 19:42 ` Bart Schaefer
2015-08-12 20:05 ` Mikael Magnusson
2015-08-12 20:57 ` Bart Schaefer
2015-08-12 21:15 ` Mikael Magnusson
2015-08-12 21:44 ` Bart Schaefer
2015-08-12 22:34 ` Mikael Magnusson [this message]
2015-08-12 22:46 ` Bart Schaefer
2015-08-12 23:37 ` Mikael Magnusson
2015-08-13 10:12 ` Oliver Kiddle
2015-08-13 20:27 ` Bart Schaefer
2015-08-14 8:44 ` Oliver Kiddle
2015-08-14 16:18 ` Mikael Magnusson
2015-08-14 16:24 ` Bart Schaefer
2015-08-14 22:31 ` Mikael Magnusson
2015-08-15 0:05 ` Bart Schaefer
2015-08-15 0:52 ` Mikael Magnusson
2015-08-12 3:05 ` PATCH 4/5: _sort: Fix syntax error Mikael Magnusson
2015-08-12 3:05 ` PATCH 5/5: _strftime: Add completion for zsh/datetime's strftime builtin Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3Rp2+h-ztEkoJcn=8b0tNt7EMiDQd17pHoSr+ckYSuLrA@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).