From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match
Date: Wed, 12 Aug 2015 11:59:58 -0700 [thread overview]
Message-ID: <150812115958.ZM14070@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3SUp2bj35KBdrkpvB+P3CnGASLzuHd8NQ+RFt0u3ZsaPw@mail.gmail.com>
On Aug 12, 8:12pm, Mikael Magnusson wrote:
} Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files di
}
} > You might want to instead check your file-patterns styles to see what
} > you've configured that broke this.
}
} You're right that it works in zsh -f, however, I don't have any
} file-patterns styles set and it still doesn't work in my setup.
}
} This is the line that breaks the desired behaviour,
} zstyle ':completion:*' list-dirs-first true
}
} Which I find to be somewhat unexpected.
I'd swear a similar conversation went by on the list sometime in the
past, but I can't find it now.
} This seems to fix it, and brings the l-d-f case in line with the
} default case below it.
I don't know that I feel strongly about this one way or another, but
according to http://www.zsh.org/mla/workers/2008/msg01119.html you are
not supposed to get an all-files tag when using list-dirs-first.
Instead you're always supposed to get "directories" and "other-files".
So instead of
pats=( " *(-/):directories:directories ${glob//:/\\:}:globbed-files" '*:all-files' )
(which BTW had a stray line break in the patch you sent) it should be
at most
pats=( " *(-/):directories:directories ${glob//:/\\:}:globbed-files" '*(-^/):other-files' )
next prev parent reply other threads:[~2015-08-12 19:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 3:04 PATCH 1/5: _git: various fixes Mikael Magnusson
2015-08-12 3:05 ` PATCH 2/5: _wget: complete headers for --header and add --no-use-server-timestamps Mikael Magnusson
2015-08-12 3:05 ` PATCH 3/5: _imagemagick: complete all files if image files didn't match Mikael Magnusson
2015-08-12 17:20 ` Oliver Kiddle
2015-08-12 18:12 ` Mikael Magnusson
2015-08-12 18:59 ` Bart Schaefer [this message]
2015-08-12 19:35 ` Mikael Magnusson
2015-08-12 19:42 ` Bart Schaefer
2015-08-12 20:05 ` Mikael Magnusson
2015-08-12 20:57 ` Bart Schaefer
2015-08-12 21:15 ` Mikael Magnusson
2015-08-12 21:44 ` Bart Schaefer
2015-08-12 22:34 ` Mikael Magnusson
2015-08-12 22:46 ` Bart Schaefer
2015-08-12 23:37 ` Mikael Magnusson
2015-08-13 10:12 ` Oliver Kiddle
2015-08-13 20:27 ` Bart Schaefer
2015-08-14 8:44 ` Oliver Kiddle
2015-08-14 16:18 ` Mikael Magnusson
2015-08-14 16:24 ` Bart Schaefer
2015-08-14 22:31 ` Mikael Magnusson
2015-08-15 0:05 ` Bart Schaefer
2015-08-15 0:52 ` Mikael Magnusson
2015-08-12 3:05 ` PATCH 4/5: _sort: Fix syntax error Mikael Magnusson
2015-08-12 3:05 ` PATCH 5/5: _strftime: Add completion for zsh/datetime's strftime builtin Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150812115958.ZM14070@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).