From: Mikael Magnusson <mikachu@gmail.com>
To: m0viefreak <m0viefreak.cm@googlemail.com>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>,
Bart Schaefer <schaefer@brasslantern.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: Add zle-line-pre-redraw hook for highlighting
Date: Mon, 11 Jan 2016 16:26:22 +0100 [thread overview]
Message-ID: <CAHYJk3SWaSvRTCbQGS5iN60JBx4Z49Emfc6dewLrxQ0w_5xrDg@mail.gmail.com> (raw)
In-Reply-To: <5692D87E.20304@googlemail.com>
On Sun, Jan 10, 2016 at 11:17 PM, m0viefreak
<m0viefreak.cm@googlemail.com> wrote:
>
>
> On 19.12.2015 10:49, Daniel Shahaf wrote:
>> Bart Schaefer wrote on Wed, Dec 16, 2015 at 00:05:01 -0800:
>>> On Dec 15, 2015 10:27 PM, "Mikael Magnusson" <mikachu@gmail.com> wrote:
>>>> I haven't received any complaints about 36650 from testers, so I'll go ahead
>>>> and push this.
>>
>> Hooray!
>>
>> This should fix between 2 and 5 z-sy-h issues:
>> https://github.com/zsh-users/zsh-syntax-highlighting/issues/245
>
> One remaining issue with this approach is the fact that this new hook is
> not triggered when a minibuffer such as isearch is active and BUFFER
> changes.
>
> Is it possible to add support for that, too?
>
> I don't know the zle internals very well, and I couldn't figure out the
> right spot to place a call to the hook without causing performance
> issues due to multiple (useless) calls.
You can probably add your redraw hook at the end of your
zle-isearch-update and zle-isearch-exit hooks (not sure if both are
needed). If you don't use them already, just point them directly at
your redraw hook function.
--
Mikael Magnusson
next prev parent reply other threads:[~2016-01-11 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 0:28 Highlight hook Mikael Magnusson
2015-12-16 6:02 ` PATCH: Add zle-line-pre-redraw hook for highlighting Mikael Magnusson
2015-12-16 8:05 ` Bart Schaefer
2015-12-19 9:49 ` Daniel Shahaf
2016-01-10 22:17 ` m0viefreak
2016-01-11 15:26 ` Mikael Magnusson [this message]
2016-01-13 0:57 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3SWaSvRTCbQGS5iN60JBx4Z49Emfc6dewLrxQ0w_5xrDg@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=m0viefreak.cm@googlemail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).