From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: German Riano <griano@yahoo.com>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: PATCH: Improve quote handling in _ant completion
Date: Wed, 29 Nov 2023 20:56:25 +0100 [thread overview]
Message-ID: <CAHYJk3Se5aCcFqKuk+fOpTF+tE5FeimQUvK3MAirz2fehaZGtw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YUfXaHAL=PR1tGB4J6gy7HDAbfwnPtiV4wzCpPC6ZFdw@mail.gmail.com>
On 11/29/23, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Tue, Nov 28, 2023 at 5:30 PM German Riano <griano@yahoo.com> wrote:
>>
>> In the current completion, if a task description contains a quote (') the
>> completions do not render properly
>>
>> In this patch I propose to build the tmp array via
>> tmp=( ${(f@)"$(command)"} )
>> and print one line at a time.
>
> Does this smaller change work instead? (I suspect the "eval" could be
> eliminated by tweaking this further.)
>
> diff --git a/Completion/Unix/Command/_ant b/Completion/Unix/Command/_ant
> index 36c7c0e89..aea3f51ec 100644
> --- a/Completion/Unix/Command/_ant
> +++ b/Completion/Unix/Command/_ant
> @@ -122,7 +122,7 @@ case $state in
> read default_target junk
> fi
> # Output target again indicating its the default one.
> - print -n "'${default_target}:(Default target) ' "
> + print -rn -- "${(qq):-${default_target}:(Default
> target) } "
> ;;
>
> (Searching:*|Main:targets:|Subtargets:|BUILD:SUCCESSFUL|Total:time:*)
> ;;
>
>> Also I am proposing to shield 'find_targets' with '((
>> $#functions[find_targets] )) ||' so that users can easily override the
>> function.
>
> No particular objection to this, though I wonder if it should be tied
> to the "targets" style and _call_program (Oliver?)
It should probably also be renamed to _ant_find_targets or something
similar, it's very unexpected that a completer pollutes the main
function namespace.
--
Mikael Magnusson
next prev parent reply other threads:[~2023-11-29 19:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <207461559.9336309.1701221332233.ref@mail.yahoo.com>
2023-11-29 1:28 ` German Riano
2023-11-29 19:18 ` Bart Schaefer
2023-11-29 19:19 ` Bart Schaefer
2023-11-29 19:56 ` Mikael Magnusson [this message]
2023-11-29 23:44 ` Bart Schaefer
2023-11-30 0:15 ` German Riano
2023-11-30 0:52 ` Bart Schaefer
2023-11-30 1:28 ` German Riano
2023-11-30 2:40 ` Bart Schaefer
2023-12-01 19:20 ` German Riano
2023-12-02 23:21 ` Bart Schaefer
2023-12-02 23:31 ` Bart Schaefer
2023-12-03 21:08 ` Oliver Kiddle
2023-12-04 0:05 ` Bart Schaefer
2023-12-04 0:11 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3Se5aCcFqKuk+fOpTF+tE5FeimQUvK3MAirz2fehaZGtw@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=griano@yahoo.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).