From: German Riano <griano@yahoo.com>
To: Mikael Magnusson <mikachu@gmail.com>,
Bart Schaefer <schaefer@brasslantern.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: PATCH: Improve quote handling in _ant completion
Date: Thu, 30 Nov 2023 00:15:10 +0000 (UTC) [thread overview]
Message-ID: <1085378061.9900970.1701303310889@mail.yahoo.com> (raw)
In-Reply-To: <CAH+w=7aB=PsBFO=osHTOuysTCL-_WFcU5VNEEgy32vT_kWQXug@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
I checked and this works. Even just using 'print -qn' works.
Questions:
1. Is "${(qq):-$ln} equivalent to "${(qq)ln} ?2. Does the read command needs '-r' ?3. Does using eval creates the risk of arbitrary execution of code?
On Wednesday, November 29, 2023 at 03:45:08 PM PST, Bart Schaefer <schaefer@brasslantern.com> wrote:
On Wed, Nov 29, 2023 at 11:56 AM Mikael Magnusson <mikachu@gmail.com> wrote:
>
> On 11/29/23, Bart Schaefer <schaefer@brasslantern.com> wrote:
> > - print -n "'${default_target}:(Default target) ' "
> > + print -rn -- "${(qq):-${default_target}:(Default target) } "
A similar change needs to be applied a bit later, I think:
(*)
# Return target and description
- print -n "'$ln' "
+ print -rn -- "${(qq):-$ln} "
;;
If this seems OK I'll prepare a proper patch.
> >> Also I am proposing to shield 'find_targets' with '((
> >> $#functions[find_targets] )) ||' so that users can easily override the
> >> function.
>
> It should probably also be renamed to _ant_find_targets or something
Agreed.
[-- Attachment #2: Type: text/html, Size: 3128 bytes --]
next prev parent reply other threads:[~2023-11-30 0:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <207461559.9336309.1701221332233.ref@mail.yahoo.com>
2023-11-29 1:28 ` German Riano
2023-11-29 19:18 ` Bart Schaefer
2023-11-29 19:19 ` Bart Schaefer
2023-11-29 19:56 ` Mikael Magnusson
2023-11-29 23:44 ` Bart Schaefer
2023-11-30 0:15 ` German Riano [this message]
2023-11-30 0:52 ` Bart Schaefer
2023-11-30 1:28 ` German Riano
2023-11-30 2:40 ` Bart Schaefer
2023-12-01 19:20 ` German Riano
2023-12-02 23:21 ` Bart Schaefer
2023-12-02 23:31 ` Bart Schaefer
2023-12-03 21:08 ` Oliver Kiddle
2023-12-04 0:05 ` Bart Schaefer
2023-12-04 0:11 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085378061.9900970.1701303310889@mail.yahoo.com \
--to=griano@yahoo.com \
--cc=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).