[PATCH 1/1] add ssh option FingerprintHash

[PATCH 1/1] add ssh option FingerprintHash

[Christian Hesse]

From: Christian Hesse <mail@eworm.de>

Signed-off-by: Christian Hesse <mail@eworm.de>
---
 Completion/Unix/Command/_ssh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
index fb8fe57..b7b7e41 100644
--- a/Completion/Unix/Command/_ssh
+++ b/Completion/Unix/Command/_ssh
@@ -219,6 +219,10 @@ _ssh () {
           _message -e 'escape character (or `none'\'')'
           ret=0
           ;;
+        (#i)fingerprinthash=*)
+          _values 'fingerprint hash algorithm' \
+              md5 ripemd160 sha1 sha256 sha384 sha512 && ret=0
+          ;;
         (#i)forwardx11timeout=*)
           _message -e 'timeout'
           ret=0
@@ -408,6 +412,7 @@ _ssh () {
                 EnableSSHKeysign \
                 EscapeChar \
                 ExitOnForwardFailure \
+                FingerprintHash \
                 ForwardAgent \
                 ForwardX11 \
                 ForwardX11Timeout \
-- 
2.5.0

Re: [PATCH 1/1] add ssh option FingerprintHash

[Mikael Magnusson]

On Wed, Aug 5, 2015 at 8:41 PM, Christian Hesse <list@eworm.de> wrote:
> From: Christian Hesse <mail@eworm.de>
>
> Signed-off-by: Christian Hesse <mail@eworm.de>
> ---
>  Completion/Unix/Command/_ssh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
> index fb8fe57..b7b7e41 100644
> --- a/Completion/Unix/Command/_ssh
> +++ b/Completion/Unix/Command/_ssh
> @@ -219,6 +219,10 @@ _ssh () {
>            _message -e 'escape character (or `none'\'')'
>            ret=0
>            ;;
> +        (#i)fingerprinthash=*)
> +          _values 'fingerprint hash algorithm' \
> +              md5 ripemd160 sha1 sha256 sha384 sha512 && ret=0

Not sure how I missed that one, thanks. My manpage only lists md5 and
sha256 as options, is it out of date?

-- 
Mikael Magnusson

Re: [PATCH 1/1] add ssh option FingerprintHash

[Christian Hesse]

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

Mikael Magnusson <mikachu@gmail.com> on Wed, 2015/08/05 21:38:
> On Wed, Aug 5, 2015 at 8:41 PM, Christian Hesse <list@eworm.de> wrote:
> > From: Christian Hesse <mail@eworm.de>
> >
> > Signed-off-by: Christian Hesse <mail@eworm.de>
> > ---
> >  Completion/Unix/Command/_ssh | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
> > index fb8fe57..b7b7e41 100644
> > --- a/Completion/Unix/Command/_ssh
> > +++ b/Completion/Unix/Command/_ssh
> > @@ -219,6 +219,10 @@ _ssh () {
> >            _message -e 'escape character (or `none'\'')'
> >            ret=0
> >            ;;
> > +        (#i)fingerprinthash=*)
> > +          _values 'fingerprint hash algorithm' \
> > +              md5 ripemd160 sha1 sha256 sha384 sha512 && ret=0
> 
> Not sure how I missed that one, thanks. My manpage only lists md5 and
> sha256 as options, is it out of date?

Oh, no... The same here. man ssh_config(5) from OpenSSH 6.9 lists md5 and
sha256 only.

I looked at the source code to find all possible algorithm. Not sure why...
Probably because man ssh(1) lists the options, but no possible values.

I've sent a patch to the openssh mailing list [0] to update ssh_config.5.
Usually some time goes by until you get a response there... Until that
happens - do we want to match documentation or code?

[0]
http://lists.mindrot.org/pipermail/openssh-unix-dev/2015-August/034275.html
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 1/1] add ssh option FingerprintHash

[Mikael Magnusson]

On Wed, Aug 5, 2015 at 10:55 PM, Christian Hesse <list@eworm.de> wrote:
> Mikael Magnusson <mikachu@gmail.com> on Wed, 2015/08/05 21:38:
>> On Wed, Aug 5, 2015 at 8:41 PM, Christian Hesse <list@eworm.de> wrote:
>> > From: Christian Hesse <mail@eworm.de>
>> >
>> > Signed-off-by: Christian Hesse <mail@eworm.de>
>> > ---
>> >  Completion/Unix/Command/_ssh | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
>> > index fb8fe57..b7b7e41 100644
>> > --- a/Completion/Unix/Command/_ssh
>> > +++ b/Completion/Unix/Command/_ssh
>> > @@ -219,6 +219,10 @@ _ssh () {
>> >            _message -e 'escape character (or `none'\'')'
>> >            ret=0
>> >            ;;
>> > +        (#i)fingerprinthash=*)
>> > +          _values 'fingerprint hash algorithm' \
>> > +              md5 ripemd160 sha1 sha256 sha384 sha512 && ret=0
>>
>> Not sure how I missed that one, thanks. My manpage only lists md5 and
>> sha256 as options, is it out of date?
>
> Oh, no... The same here. man ssh_config(5) from OpenSSH 6.9 lists md5 and
> sha256 only.
>
> I looked at the source code to find all possible algorithm. Not sure why...
> Probably because man ssh(1) lists the options, but no possible values.
>
> I've sent a patch to the openssh mailing list [0] to update ssh_config.5.
> Usually some time goes by until you get a response there... Until that
> happens - do we want to match documentation or code?

As long as they options work, we might as well complete them. Thanks
for double checking :).

-- 
Mikael Magnusson