Fwd: Problem with RM_STAR_WAIT

Fwd: Problem with RM_STAR_WAIT

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Probably this is more important for zsh-workers list.

---------- Forwarded message ----------
From: İsmail Dönmez <ismail@donmez.ws>
Date: Thu, Nov 14, 2013 at 1:59 PM
Subject: Problem with RM_STAR_WAIT
To: zsh-users@zsh.org


[/havana/t/z]> setopt RM_STAR_WAIT

[/havana/t/z]> touch a b c d e

[/havana/t/z]> rm *
zsh: sure you want to delete all the files in /havana/t/z? (waiting ten
seconds)^C
 [yn]? y

[/havana/t/z]> ls
a  b  c  d  e

After CTRL-C I think zsh should just stop processing and don't ask the
yes/no, because entering 'y' here has no effect.

Also, is there a way to change the time interval (default is 10 seconds) ?

Regards,
ismail

Re: Fwd: Problem with RM_STAR_WAIT

[Bart Schaefer]

On Nov 19,  2:04pm, Ismail Donmez wrote:
}
} Probably this is more important for zsh-workers list.

zsh-workers receives everything sent to zsh-users ... I saw this before
but didn't have time to do anything with it right then and so left it
for someone else.  Apparently everyone else did, too.

} [/havana/t/z]> rm *
} zsh: sure you want to delete all the files in /havana/t/z? (waiting ten
} seconds)^C
}  [yn]? y
} 
} After CTRL-C I think zsh should just stop processing and don't ask the
} yes/no, because entering 'y' here has no effect.

This is pretty simple to fix.  A ctrl+c here must have been effective at
some point in the past, I'd think, or there'd be no point in waiting the
ten seconds, since we next block forever at the [y/n] prompt.

Patch below.

} Also, is there a way to change the time interval (default is 10 seconds) ?

No, and I'm definitely leaving that for someone else.


diff --git a/Src/utils.c b/Src/utils.c
index d1d9406..0db9c30 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2299,6 +2299,8 @@ checkrmall(char *s)
 	sleep(10);
 	fputc('\n', shout);
     }
+    if (errflag)
+      return 0;
     fputs(" [yn]? ", shout);
     fflush(shout);
     zbeep();

Re: Fwd: Problem with RM_STAR_WAIT

[Bart Schaefer]

On Nov 19,  8:21am, Bart Schaefer wrote:
}
} A ctrl+c here must have been effective at
} some point in the past, I'd think, or there'd be no point in waiting the
} ten seconds

D'oh.  Ignore that part ...

Re: Fwd: Problem with RM_STAR_WAIT

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Tue, Nov 19, 2013 at 6:21 PM, Bart Schaefer <schaefer@brasslantern.com>wrote:

> On Nov 19,  2:04pm, Ismail Donmez wrote:
> }
> } Probably this is more important for zsh-workers list.
>
> zsh-workers receives everything sent to zsh-users ... I saw this before
> but didn't have time to do anything with it right then and so left it
> for someone else.  Apparently everyone else did, too.
>
> } [/havana/t/z]> rm *
> } zsh: sure you want to delete all the files in /havana/t/z? (waiting ten
> } seconds)^C
> }  [yn]? y
> }
> } After CTRL-C I think zsh should just stop processing and don't ask the
> } yes/no, because entering 'y' here has no effect.
>
> This is pretty simple to fix.  A ctrl+c here must have been effective at
> some point in the past, I'd think, or there'd be no point in waiting the
> ten seconds, since we next block forever at the [y/n] prompt.
>
> Patch below.
>
>
Works fine, thanks a lot!