zsh-workers
 help / color / mirror / code / Atom feed
From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: Slowdown around 5.0.5-dev-0
Date: Wed, 14 Oct 2015 08:50:00 +0200	[thread overview]
Message-ID: <CAKc7PVC4rcOD-Os9mgGf2JR4yY0CeG4m1kyPQ3gp67P_-xFDWg@mail.gmail.com> (raw)
In-Reply-To: <151013085246.ZM30504@torch.brasslantern.com>

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

With this patch the list is instant fast. It can be seen here:

https://youtu.be/jwBZY6fmQHs

(the zprof result – 1.9x speed up – doesn't fully express how fast is the list)

I attach results for browsing the list and searching through it.
Searching is faster 2.15 times and 1.88 times.

What's interesting is lower RES for the new patch. It's like with the
new patch RES can easier go down after peak. I once saw 179M after
peak of ~400M. The two-patches version can also go down, but maybe not
that easy. So this is quite confusing. I think a more synthetic
testing is needed to recognize how the memory behaves. Now I manually
open a script, give it a work, run htop.

Maybe the patch isn't that bad? Instant fast list is a great thing for me.

Best regards,
Sebastian Gniazdowski

[-- Attachment #2: result_search3.txt --]
[-- Type: text/plain, Size: 3970 bytes --]

=== searching for "sy s" (translated to *sy*~^*s*) ===

new patch:
num  calls                time                       self            name
-----------------------------------------------------------------------------------
 1)    1       10195,21 10195,21   99,94%   9943,58  9943,58   97,47%  n-list
 2)  161         212,69     1,32    2,08%    212,69     1,32    2,08%  _nlist_print_with_ansi
 3)    4          24,20     6,05    0,24%     24,20     6,05    0,24%  _nlist_cursor_visibility
 4)    7         228,66    32,67    2,24%     15,97     2,28    0,16%  n-list-draw
 5)    7          15,94     2,28    0,16%      3,12     0,45    0,03%  n-list-input
 6)    1           6,22     6,22    0,06%      0,73     0,73    0,01%  _nlist_exit
 7)    7           0,49     0,07    0,00%      0,43     0,06    0,00%  _nlist_setup_user_vars
 8)    7           0,31     0,04    0,00%      0,31     0,04    0,00%  _nlist_status_msg
( n-panelize < ~/lsoflsof; )  10,59s user 1,08s system 95% cpu 12,228 total

RES: 318M

two previous patches (from repository):
num  calls                time                       self            name
-----------------------------------------------------------------------------------
 1)  161       11294,81    70,15   51,38%  11294,81    70,15   51,38%  _nlist_print_with_ansi
 2)    1       21965,97 21965,97   99,93%   9726,11  9726,11   44,25%  n-list
 3)    7       12150,96  1735,85   55,28%    856,14   122,31    3,89%  n-list-draw
 4)    7          79,61    11,37    0,36%     61,09     8,73    0,28%  n-list-input
 5)    4          32,33     8,08    0,15%     32,33     8,08    0,15%  _nlist_cursor_visibility
 6)    1          15,82    15,82    0,07%      7,81     7,81    0,04%  _nlist_exit
 7)    7           2,85     0,41    0,01%      2,78     0,40    0,01%  _nlist_setup_user_vars
 8)    7           0,32     0,05    0,00%      0,32     0,05    0,00%  _nlist_status_msg
( n-panelize < ~/lsoflsof; )  22,37s user 0,93s system 97% cpu 23,972 total

RES: 492M

=== searching for "s" ===

new patch:
num  calls                time                       self            name
-----------------------------------------------------------------------------------
 1)    1        5199,43  5199,43   99,88%   5048,37  5048,37   96,98%  n-list
 2)   92         117,53     1,28    2,26%    117,53     1,28    2,26%  _nlist_print_with_ansi
 3)    4          27,57     6,89    0,53%     27,57     6,89    0,53%  _nlist_cursor_visibility
 4)    4         126,26    31,57    2,43%      8,74     2,18    0,17%  n-list-draw
 5)    4          18,59     4,65    0,36%      2,20     0,55    0,04%  n-list-input
 6)    1           6,29     6,29    0,12%      0,73     0,73    0,01%  _nlist_exit
 7)    4           0,27     0,07    0,01%      0,21     0,05    0,00%  _nlist_setup_user_vars
 8)    4           0,14     0,04    0,00%      0,14     0,04    0,00%  _nlist_status_msg
( n-panelize < ~/lsoflsof; )  6,21s user 0,63s system 94% cpu 7,237 total

RES: 446M

two previous patches (from repository):
num  calls                time                       self            name
-----------------------------------------------------------------------------------
 1)    1        9781,26  9781,26   99,86%   4805,60  4805,60   49,06%  n-list
 2)   92        4583,54    49,82   46,80%   4583,54    49,82   46,80%  _nlist_print_with_ansi
 3)    4        4897,09  1224,27   50,00%    313,55    78,39    3,20%  n-list-draw
 4)    4          69,30    17,33    0,71%     52,21    13,05    0,53%  n-list-input
 5)    4          29,65     7,41    0,30%     29,65     7,41    0,30%  _nlist_cursor_visibility
 6)    1          13,58    13,58    0,14%      7,17     7,17    0,07%  _nlist_exit
 7)    4           2,79     0,70    0,03%      2,71     0,68    0,03%  _nlist_setup_user_vars
 8)    4           0,18     0,05    0,00%      0,18     0,05    0,00%  _nlist_status_msg
( n-panelize < ~/lsoflsof; )  10,88s user 0,52s system 96% cpu 11,779 total

RES: 439M

[-- Attachment #3: result5.txt --]
[-- Type: text/plain, Size: 1913 bytes --]

new patch:
num  calls                time                       self            name
-----------------------------------------------------------------------------------
 1)    1         965,93   965,93   99,29%    908,88   908,88   93,42%  n-list
 2)  161          34,56     0,21    3,55%     34,56     0,21    3,55%  _nlist_print_with_ansi
 3)    7          49,01     7,00    5,04%     14,44     2,06    1,48%  n-list-draw
 4)    2          11,36     5,68    1,17%     11,36     5,68    1,17%  _nlist_cursor_visibility
 5)    7           2,18     0,31    0,22%      2,08     0,30    0,21%  n-list-input
 6)    1           6,94     6,94    0,71%      0,53     0,53    0,05%  _nlist_exit
 7)    7           0,55     0,08    0,06%      0,38     0,05    0,04%  _nlist_setup_user_vars
 8)    7           0,25     0,04    0,03%      0,25     0,04    0,03%  _nlist_status_msg
( n-panelize < ~/lsoflsof; )  2,50s user 0,17s system 87% cpu 3,055 total

two previous patches (from HEAD):
num  calls                time                       self            name
-----------------------------------------------------------------------------------
 1)    1        1861,59  1861,59   99,22%   1082,47  1082,47   57,70%  n-list
 2)  161         486,65     3,02   25,94%    486,65     3,02   25,94%  _nlist_print_with_ansi
 3)    7         738,66   105,52   39,37%    252,01    36,00   13,43%  n-list-draw
 4)    7          25,10     3,59    1,34%     24,97     3,57    1,33%  n-list-input
 5)    2          12,54     6,27    0,67%     12,54     6,27    0,67%  _nlist_cursor_visibility
 6)    7           9,61     1,37    0,51%      9,37     1,34    0,50%  _nlist_setup_user_vars
 7)    1          14,61    14,61    0,78%      7,32     7,32    0,39%  _nlist_exit
 8)    7           0,39     0,06    0,02%      0,39     0,06    0,02%  _nlist_status_msg
( n-panelize < ~/lsoflsof; )  3,20s user 0,17s system 85% cpu 3,928 total


  reply	other threads:[~2015-10-14  6:50 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10 10:54 Sebastian Gniazdowski
2015-10-10 17:58 ` Bart Schaefer
2015-10-10 18:11   ` Sebastian Gniazdowski
2015-10-10 18:32     ` Sebastian Gniazdowski
2015-10-11  0:06       ` Bart Schaefer
2015-10-11  6:20         ` Bart Schaefer
2015-10-11  8:39           ` Sebastian Gniazdowski
2015-10-11 16:17             ` Bart Schaefer
2015-10-11 16:48               ` Sebastian Gniazdowski
2015-10-11 17:31                 ` Bart Schaefer
2015-10-11 18:05                   ` Sebastian Gniazdowski
2015-10-11 21:22                     ` Bart Schaefer
2015-10-12  8:21                       ` Sebastian Gniazdowski
2015-10-12 14:01                         ` Bart Schaefer
2015-10-12 16:50                           ` Sebastian Gniazdowski
2015-10-13  0:33                             ` Bart Schaefer
2015-10-13  8:21                               ` Sebastian Gniazdowski
2015-10-13 15:52                                 ` Bart Schaefer
2015-10-14  6:50                                   ` Sebastian Gniazdowski [this message]
2015-10-14 13:27                                   ` Peter Stephenson
2015-10-14 16:25                                     ` Bart Schaefer
2015-10-14 16:50                                       ` Bart Schaefer
2015-10-15  4:32                                         ` Bart Schaefer
2015-10-15 13:03                                           ` Sebastian Gniazdowski
2015-10-16  0:35                                             ` Bart Schaefer
2015-10-17  9:12                                               ` Sebastian Gniazdowski
2015-10-17  9:24                                                 ` Sebastian Gniazdowski
2015-10-18 16:19                                                 ` Bart Schaefer
2015-10-18 20:40                                                   ` Sebastian Gniazdowski
2015-10-18 21:07                                                     ` Bart Schaefer
2015-10-18 21:31                                                       ` Sebastian Gniazdowski
2015-10-19 17:21                                                         ` Bart Schaefer
2015-10-22 12:49                                                           ` Sebastian Gniazdowski
2015-10-22 15:00                                                             ` Bart Schaefer
2015-10-22 16:28                                                               ` Sebastian Gniazdowski
2015-10-22 16:33                                                                 ` Sebastian Gniazdowski
2015-10-23 15:40                                                               ` Sebastian Gniazdowski
2015-10-23 15:57                                                                 ` Sebastian Gniazdowski
2015-10-23 19:26                                                                   ` Bart Schaefer
2015-10-23 23:50                                                                     ` Bart Schaefer
2015-10-24  6:09                                                                       ` Sebastian Gniazdowski
2015-10-24  7:37                                                                         ` Sebastian Gniazdowski
2015-10-24  8:04                                                                           ` Sebastian Gniazdowski
2015-10-24 19:39                                                                           ` Bart Schaefer
2015-10-25  7:35                                                                             ` Sebastian Gniazdowski
2015-10-25 17:23                                                                               ` Bart Schaefer
2015-10-25 20:56                                                                                 ` Sebastian Gniazdowski
2015-10-26  0:49                                                                                   ` Bart Schaefer
2015-10-26  7:41                                                                                     ` Sebastian Gniazdowski
2015-10-26  7:47                                                                                       ` Sebastian Gniazdowski
2015-10-24  6:27                                                                       ` Sebastian Gniazdowski
2015-10-24 10:54                                                                       ` Sebastian Gniazdowski
2015-10-24 11:25                                                                         ` Sebastian Gniazdowski
2015-10-24 16:31                                                                         ` Bart Schaefer
2015-10-24 16:41                                                                           ` Bart Schaefer
2015-10-23  6:32                                                             ` Sebastian Gniazdowski
2015-10-16  0:37                                             ` Bart Schaefer
2015-10-13 13:07                         ` Sebastian Gniazdowski
2015-10-13 13:31                           ` Sebastian Gniazdowski
2015-10-12 12:05                       ` Sebastian Gniazdowski
2015-10-12 15:13                         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKc7PVC4rcOD-Os9mgGf2JR4yY0CeG4m1kyPQ3gp67P_-xFDWg@mail.gmail.com \
    --to=sgniazdowski@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).