* Non-bug in quotestring()/utils.c
@ 2015-09-22 7:54 Sebastian Gniazdowski
2015-09-22 15:36 ` Bart Schaefer
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Gniazdowski @ 2015-09-22 7:54 UTC (permalink / raw)
To: zsh-workers
Hello,
when compiling, the following warning is issued:
utils.c:5392:6: warning: expression result unused [-Wunused-value]
*u++;
The expression is the same as *(u++). Maybe the author used the
"after"-++ to expect that it will be applied after dereference? What
actually happens is that it is the dereference that is applied last.
On the other hand, the code:
if (inull(*u))
*u++;
- the "if character 0 then skip it" - looks sensible. As there are no
bugs reported about quoting string, the line should probably be
changed to simple u++. So I entitled the email "non-bug", seeing
nothing harmful happens. What is the quoting "QT_DOLLARS", to do some
tests before applying a patch?
Best regards,
Sebastian Gniazdowski
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Non-bug in quotestring()/utils.c
2015-09-22 7:54 Non-bug in quotestring()/utils.c Sebastian Gniazdowski
@ 2015-09-22 15:36 ` Bart Schaefer
2015-09-23 8:41 ` Sebastian Gniazdowski
0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2015-09-22 15:36 UTC (permalink / raw)
To: zsh-workers
Already reported/fixed/pushed.
--
Barton E. Schaefer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Non-bug in quotestring()/utils.c
2015-09-22 15:36 ` Bart Schaefer
@ 2015-09-23 8:41 ` Sebastian Gniazdowski
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Gniazdowski @ 2015-09-23 8:41 UTC (permalink / raw)
To: Bart Schaefer; +Cc: zsh-workers
Hello,
I now see that I misinterpreted *u++ as *(u++). The addition will be
applied last.
Best regards,
Sebastian Gniazdowski
On 22 September 2015 at 17:36, Bart Schaefer <schaefer@brasslantern.com> wrote:
> Already reported/fixed/pushed.
>
> --
> Barton E. Schaefer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-23 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-22 7:54 Non-bug in quotestring()/utils.c Sebastian Gniazdowski
2015-09-22 15:36 ` Bart Schaefer
2015-09-23 8:41 ` Sebastian Gniazdowski
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).