patch: completion for stgit `--patch` option

patch: completion for stgit `--patch` option

[Alexandre Rames]

[-- Attachment #1.1: Type: text/plain, Size: 296 bytes --]

Here is a patch adding completion support for stgit `--patch` option.

With the patch applied I get:
$ stg ser
+ bar_feature
> foo_feature

$ stg refresh --patch bar_feature
 -- patch --
bar_feature  foo_feature

If that is of any interest, what's the process to get this in?

Cheers,

Alexandre

[-- Attachment #1.2: Type: text/html, Size: 413 bytes --]

[-- Attachment #2: zsh_stgit_comp.patch --]
[-- Type: text/x-patch, Size: 821 bytes --]

commit 8e7f84ddda81280812a5082ff82209c30928b17e
Author: Alexandre Rames <alexandre.rames@arm.com>
Date:   Thu Sep 4 15:21:39 2014 +0100

    Add completion for stgit `--patch` option.

diff --git a/Completion/Unix/Command/_stgit b/Completion/Unix/Command/_stgit
index b2f2aea..6248267 100644
--- a/Completion/Unix/Command/_stgit
+++ b/Completion/Unix/Command/_stgit
@@ -32,6 +32,17 @@ else
 	compadd $(stg series --noprefix 2> /dev/null) \
 		&& ret=0
     ;;
+    (ref*)
+      last_word="$words[$CURRENT-1]"
+      refresh_patch_options=( -p --patch )
+      if [[ -n ${refresh_patch_options[(r)$last_word]} ]]; then
+	_wanted -V "applied patches" expl "patch" \
+	  compadd ${${(M)${(f)"$(stg series 2> /dev/null)"}##[+>] *}#[+>] } \
+		  && ret=0
+      else
+	_files
+      fi
+    ;;
     (*)
       _files
     ;;

Re: patch: completion for stgit `--patch` option

[Peter Stephenson]

On Thu, 04 Sep 2014 15:28:11 +0100
Alexandre Rames <alexandre@uop.re> wrote:
> Here is a patch adding completion support for stgit `--patch` option.
>
> If that is of any interest, what's the process to get this in?

You wait for me to add it, which I've just done.

pws

Re: patch: completion for stgit `--patch` option

[Alexandre Rames]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Well I didn't have to wait, it was too quick! Thanks.


On Thu, Sep 4, 2014 at 3:50 PM, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> On Thu, 04 Sep 2014 15:28:11 +0100
> Alexandre Rames <alexandre@uop.re> wrote:
> > Here is a patch adding completion support for stgit `--patch` option.
> >
> > If that is of any interest, what's the process to get this in?
>
> You wait for me to add it, which I've just done.
>
> pws
>