Completion for stgit squash subcommand

Completion for stgit squash subcommand

[Alexandre Rames]

[-- Attachment #1.1: Type: text/plain, Size: 119 bytes --]

Hi there,

Here is a patch to add completion for the stgit squash command. It is
trivial, but oh so useful!

Alexandre

[-- Attachment #1.2: Type: text/html, Size: 188 bytes --]

[-- Attachment #2: zsh.stgit.squash.completion.patch --]
[-- Type: application/octet-stream, Size: 748 bytes --]

commit c21d5a11e75f26a194dff0725176f3a9e21c1993
Author: Alexandre Rames <alexandre@uop.re>
Date:   Tue Mar 21 13:34:41 2017 -0700

    Add completion for the `stgit` `squash` subcommand.

diff --git a/Completion/Unix/Command/_stgit b/Completion/Unix/Command/_stgit
index f313f65..f05591b 100644
--- a/Completion/Unix/Command/_stgit
+++ b/Completion/Unix/Command/_stgit
@@ -27,7 +27,7 @@ else
 	compadd ${${(M)${(f)"$(stg series 2> /dev/null)"}##[+>] *}#[+>] } \
 		&& ret=0
     ;;
-    (edit|files|goto|rename|log|float|delete|sink|mail|sync|show|pick|hide)
+    (edit|files|goto|rename|log|float|delete|sink|mail|sync|show|pick|hide|squash)
       _wanted -V "patches" expl "patch" \
 	compadd $(stg series --noprefix 2> /dev/null) \
 		&& ret=0

Request for review: Completion for stgit squash subcommand

[Alexandre Rames]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hi there,

Was that the right place to request a review? If not where should I send
the patch?

Cheers,

Alexandre

On Wed, 22 Mar 2017 at 09:32 Alexandre Rames <alexandre@uop.re> wrote:

> Hi there,
>
> Here is a patch to add completion for the stgit squash command. It is
> trivial, but oh so useful!
>
> Alexandre
>

Re: Request for review: Completion for stgit squash subcommand

[Peter Stephenson]

On Fri, 24 Mar 2017 16:23:39 +0000
Alexandre Rames <alexandre@uop.re> wrote:
> Was that the right place to request a review? If not where should I send
> the patch?

This is the right place, but I suppose no one has owned up to knowing
about stgit.

It's a simple patch, I'll just commit it.

pws

Re: Request for review: Completion for stgit squash subcommand

[Alexandre Rames]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Thanks !
On Fri, 24 Mar 2017 at 09:36, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> On Fri, 24 Mar 2017 16:23:39 +0000
> Alexandre Rames <alexandre@uop.re> wrote:
> > Was that the right place to request a review? If not where should I send
> > the patch?
>
> This is the right place, but I suppose no one has owned up to knowing
> about stgit.
>
> It's a simple patch, I'll just commit it.
>
> pws
>