From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: "Tomasz Kłoczko" <kloczko.tomasz@gmail.com>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Fwd: 5.8: LTO exposes some new issues
Date: Mon, 27 Jul 2020 16:19:54 +0200 [thread overview]
Message-ID: <CAN=4vMrfmPBoS9i5aCSZA5bPuPnjboZ7BNN7poDGPy9ra3BeKQ@mail.gmail.com> (raw)
In-Reply-To: <CABB28CzqX8id_xr8O7H-EM8a9wUWf5iH8WRS8Sr3_rgyLtnumg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On Mon, Jul 27, 2020 at 2:47 PM Tomasz Kłoczko <kloczko.tomasz@gmail.com> wrote:
> Here is whole list of compile and linking warnings:
>
> utils.c: In function 'getkeystring':
> lto1: warning: function may return address of local variable [-Wreturn-local-addr]
> utils.c:6644:16: note: declared here
> 6644 | char *buf, tmp[1];
> | ^
This one might be a real bug. At the end of getkeystring there is an
explicit check for `how & GETKEY_SINGLE_CHAR`. If this condition is
true at that point, the code runs into undefined behavior. First,
writing to `*t` is illegal because it points outside of `tmp`. Second,
returning `buf` is illegal because it holds a pointer to a local
variable (hence the warning).
I'm attaching a patch that keeps the branch (although I'm not sure
it's reachable) and makes the code less broken if it ever triggers. I
cannot verify that it gets rid of the warning because I don't get this
warning with unmodified code.
FYI: I won't be doing anything about the warning in gettempname (which
I'm not getting with my toolchain).
Roman.
[-- Attachment #2: explicit-single-char-return.txt --]
[-- Type: text/plain, Size: 593 bytes --]
diff --git a/Src/utils.c b/Src/utils.c
index 5151b89a8..e03f41468 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -7162,11 +7162,13 @@ getkeystring(char *s, int *len, int how, int *misc)
*/
DPUTS((how & (GETKEY_DOLLAR_QUOTE|GETKEY_UPDATE_OFFSET)) ==
GETKEY_DOLLAR_QUOTE, "BUG: unterminated $' substitution");
+ if (how & GETKEY_SINGLE_CHAR) {
+ *misc = 0;
+ return s;
+ }
*t = '\0';
if (how & GETKEY_DOLLAR_QUOTE)
*tdest = '\0';
- if (how & GETKEY_SINGLE_CHAR)
- *misc = 0;
else
*len = ((how & GETKEY_DOLLAR_QUOTE) ? tdest : t) - buf;
return buf;
next prev parent reply other threads:[~2020-07-27 14:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 23:41 Tomasz Kłoczko
2020-07-22 5:59 ` Daniel Shahaf
2020-07-25 17:43 ` Bart Schaefer
[not found] ` <CABB28CxSD5w-SY-iCVYuQ4kJfBpNJOWhpk4HOrS1DNPfMVztgw@mail.gmail.com>
2020-07-25 20:05 ` Fwd: " Bart Schaefer
2020-07-27 2:12 ` Daniel Shahaf
2020-07-27 10:07 ` Tomasz Kłoczko
2020-07-27 11:09 ` Roman Perepelitsa
2020-07-27 12:19 ` Roman Perepelitsa
2020-07-27 12:46 ` Tomasz Kłoczko
2020-07-27 14:13 ` Roman Perepelitsa
2020-07-27 14:19 ` Roman Perepelitsa [this message]
2020-07-28 8:09 ` Daniel Shahaf
2020-07-28 10:55 ` Fwd: " Roman Perepelitsa
2020-07-28 8:19 ` Daniel Shahaf
2020-07-28 7:53 ` Daniel Shahaf
2020-07-28 8:25 ` Peter Stephenson
2020-07-28 10:52 ` Roman Perepelitsa
2020-07-28 11:19 ` Daniel Shahaf
2020-07-28 11:31 ` Roman Perepelitsa
2020-07-28 11:51 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN=4vMrfmPBoS9i5aCSZA5bPuPnjboZ7BNN7poDGPy9ra3BeKQ@mail.gmail.com' \
--to=roman.perepelitsa@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=kloczko.tomasz@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).