Lack of sanitisation of I/O in pushd/popd

Lack of sanitisation of I/O in pushd/popd

[Joao Paulo]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Hello,

I am encountering some problems with the implementation of the pushd and
popd. The spaces in directory paths should be sanitise so I can read them
properly. This is if I have a folder named Google Drive in my home
directory, I expect it to be `~/Google\ Drive` not `~/Google Drive`, this
is causing me problems to read the data from the `popd -n` because there is
no difference between that whitespace, and the whitespace used to print
elements in the stack.

Best Regards,

João Paulo

Re: Lack of sanitisation of I/O in pushd/popd

[Leah Neukirchen]

Joao Paulo <joaolrpaulo@gmail.com> writes:

> Hello,
>
> I am encountering some problems with the implementation of the pushd and
> popd. The spaces in directory paths should be sanitise so I can read them
> properly. This is if I have a folder named Google Drive in my home
> directory, I expect it to be `~/Google\ Drive` not `~/Google Drive`, this
> is causing me problems to read the data from the `popd -n` because there is
> no difference between that whitespace, and the whitespace used to print
> elements in the stack.

popd -n is not even documented, and more a sideeffect of the
implementation that it works.

You can list the stack with "dirs -p" linewise, or just access the
array $dirstack directly.

hth,
-- 
Leah Neukirchen  <leah@vuxu.org>  http://leah.zone

Re: Lack of sanitisation of I/O in pushd/popd

[Mikael Magnusson]

On Mon, Feb 19, 2018 at 5:34 PM, Joao Paulo <joaolrpaulo@gmail.com> wrote:
> Hello,
>
> I am encountering some problems with the implementation of the pushd and
> popd. The spaces in directory paths should be sanitise so I can read them
> properly. This is if I have a folder named Google Drive in my home
> directory, I expect it to be `~/Google\ Drive` not `~/Google Drive`, this
> is causing me problems to read the data from the `popd -n` because there is
> no difference between that whitespace, and the whitespace used to print
> elements in the stack.

If you're wrapping popd in a function, you can just access the
directory stack elements via $dirstack. The user can disable popd
printing anything at all with setopt pushd_silent anyway.

-- 
Mikael Magnusson

Re: Lack of sanitisation of I/O in pushd/popd

[Mikael Magnusson]

On Mon, Feb 19, 2018 at 7:22 PM, Joao Paulo <joaolrpaulo@gmail.com> wrote:
> Thanks for the tip, but the information of $dirstack is the same as the
> `popd -n` so, it is not sanitizing the output as well.
>
> I think the problem is with pushd not validating if the current folder as
> some space in the middle.

Read the section about arrays in the manpage.

-- 
Mikael Magnusson

Re: Lack of sanitisation of I/O in pushd/popd

[Joao Paulo]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Holy... My bad, thanks for the help.

On Mon, Feb 19, 2018, 18:31 Mikael Magnusson <mikachu@gmail.com> wrote:

> On Mon, Feb 19, 2018 at 7:22 PM, Joao Paulo <joaolrpaulo@gmail.com> wrote:
> > Thanks for the tip, but the information of $dirstack is the same as the
> > `popd -n` so, it is not sanitizing the output as well.
> >
> > I think the problem is with pushd not validating if the current folder as
> > some space in the middle.
>
> Read the section about arrays in the manpage.
>
> --
> Mikael Magnusson
>