FreeBSD zsh port fixes

FreeBSD zsh port fixes

[Phil Pennock]

Two issues; one an FYI, the other appears more problematic.

Saw a change flow by, affecting the FreeBSD Ports build of zsh:
  https://github.com/freebsd/freebsd-ports/tree/master/shells/zsh

Change:
  https://github.com/freebsd/freebsd-ports/commit/0e5ab95752577d446d06f83b25477a997ff6b52c

Changes are to add `-DBOOL_DEFINED` to CPPFLAGS and to put
`zsh_cv_sys_path_dev_fd=no` into environ before configure.

Bug 183253:
  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183253
Bug 180178:
  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=180178

It looks like for 183253 the FreeBSD folks are investigating the
definition of bool in the NIS sub-system but perhaps worth looking at a
fix in zsh on the same basis as the Solaris fix between curses and,
again, NIS.

For 180178, note that the FreeBSD pkg notes for bash warn to have
/dev/fd be fdescfs mounted, so if zsh requires the same as bash, we're
not in bad shape; note that if /dev/fd is not fdescfs, then it's
FreeBSD devfs and only 0, 1 and 2 will exist -- they're special-cased.
-- 
My employer, Apcera Inc, is hiring sysadmin; primarily San Francisco:
 http://www.apcera.com/jobs/#operations-engineer
(but all the mistakes in this email are made in my personal capacity)

Re: FreeBSD zsh port fixes

[Baptiste Daroussin]

2014-06-23 3:32 GMT+02:00 Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>:
> Two issues; one an FYI, the other appears more problematic.
>
> Saw a change flow by, affecting the FreeBSD Ports build of zsh:
>   https://github.com/freebsd/freebsd-ports/tree/master/shells/zsh
>
> Change:
>   https://github.com/freebsd/freebsd-ports/commit/0e5ab95752577d446d06f83b25477a997ff6b52c
>

I'm lurking here, if I didn't upstream those patches, it is because
they are either freebsd only
(BOOL_DEFINED is due to FreeBSD namespace pollution in nis headers
that I do need to fix)
or due to a FreeBSD specific thing, fdescfs is a special filesystem on
FreeBSD tha

Re: FreeBSD zsh port fixes

[Baptiste Daroussin]

2014-06-23 3:32 GMT+02:00 Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>:
> Two issues; one an FYI, the other appears more problematic.
>
> Saw a change flow by, affecting the FreeBSD Ports build of zsh:
>   https://github.com/freebsd/freebsd-ports/tree/master/shells/zsh
>
> Change:
>   https://github.com/freebsd/freebsd-ports/commit/0e5ab95752577d446d06f83b25477a997ff6b52c
>
> Changes are to add `-DBOOL_DEFINED` to CPPFLAGS and to put
> `zsh_cv_sys_path_dev_fd=no` into environ before configure.
>
> Bug 183253:
>   https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183253
> Bug 180178:
>   https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=180178
I'm lurking here, if I didn't upstream those patches, it is because
they are either freebsd only
(BOOL_DEFINED is due to FreeBSD namespace pollution in nis headers
that I do need to fix)
or due to a FreeBSD specific thing, fdescfs is a special filesystem on
FreeBSD that is only mounted in special cases (basically mostly needed
for openjdk)
The package builders do mount it to allow java package to properly get
built and this triggered
the bug that official packages where built with /dev/fd support while
most of end user where having
a system without it mounting resulting in some problems.

I don't think this has anything to do with ZSH but this is both a
FreeBSD only problem
BTW

regards,
Bapt