From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 1/4] Update system_profiler completion
Date: Fri, 25 Aug 2023 13:56:16 +0900 [thread overview]
Message-ID: <FEC7E9C7-ECB4-4155-A6C5-1863129AB12E@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20230823040004.171642-2-syohex@gmail.com>
> 2023/08/23 13:00, Shohei YOSHIDA <syohex@gmail.com> wrote:
>
> ---
> Completion/Darwin/Command/_system_profiler | 3 ++-
The patch is OK, of course.
But _system_profiler has the following comment:
# TODO: Should this be static? Calling `system_profiler -listDataTypes` takes
# about 0.07-0.08 secs on my machine. Does this list ever change (between
# different versions of OS X)?
_data_types=( SP{AirPort,Applications,Audio,...(snip)...,WWAN}DataType )
# the dynamic alternative is:
#_data_types=( ${${(f)"$(_call_program path system_profiler -listDataTypes 2>/dev/null)"}[2,-1]} )
At least on macOS Ventura (the latest), "system_profiler -listDataTypes"
gives somewhat different list of data types. And I think the time
required by this command is negligible (I can't notice any delay).
So isn't it better to use the 'dynamic alternative' in the above comment?
The tag name 'path' used in the _call_program is not appropriate.
It would be better to use, for example, 'data-types'.
next prev parent reply other threads:[~2023-08-25 4:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 4:00 [PATCH 0/4] Update macOS command completions Shohei YOSHIDA
2023-08-23 4:00 ` [PATCH 1/4] Update system_profiler completion Shohei YOSHIDA
2023-08-25 4:56 ` Jun T [this message]
2023-08-25 5:24 ` Shohei Yoshida
2023-08-27 7:02 ` Shohei Yoshida
2023-08-25 5:11 ` Jun T
2023-08-23 4:00 ` [PATCH 2/4] Update sw_vers completion Shohei YOSHIDA
2023-08-25 5:01 ` Jun T
2023-08-25 5:29 ` Shohei Yoshida
2023-08-27 6:53 ` Shohei Yoshida
2023-08-23 4:00 ` [PATCH 3/4] Update otool completion Shohei YOSHIDA
2023-08-25 15:16 ` Jun. T
[not found] ` <CAFX6MONwMeWWVmUScwqq1zUiHhebF6+fhi3kvDk1pP=VR7y_oQ@mail.gmail.com>
[not found] ` <F45E2407-3AFA-4925-A247-98013FB3EEAF@kba.biglobe.ne.jp>
2023-08-28 2:32 ` Shohei Yoshida
2023-08-28 4:02 ` Jun T
2023-08-23 4:00 ` [PATCH 4/4] Update open completion Shohei YOSHIDA
2023-08-25 16:07 ` Jun. T
2023-08-27 7:18 ` Shohei Yoshida
[not found] ` <CAH+w=7Z3AKE4Z3EKN7j9Qh+0UPzJgWjibJ7LmqFQ5xN+QSr5Sw@mail.gmail.com>
2023-08-28 1:53 ` Jun. T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FEC7E9C7-ECB4-4155-A6C5-1863129AB12E@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).