Bug: wrong completion for 'git rerere forget'

Bug: wrong completion for 'git rerere forget'

[ronso0]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

(Originally and mistakenly reported as ohmyzsh issue 
<https://github.com/ohmyzsh/ohmyzsh/issues/11358>)

|"git rerere forg"<Tab>| completes to "|git rerere forget=" (should be 
just "||git rerere forget "| with a trailing space)
Add a file path, hit Return and it fails (prints the usage hint)

This occurs with zsh 5.8 on Ubuntu 20.04 with xfce.

Thanks for taking care!
ronso0

[-- Attachment #2: Type: text/html, Size: 780 bytes --]

[PATCH] Re: Bug: wrong completion for 'git rerere forget'

[Bart Schaefer]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

On Mon, Dec 5, 2022 at 4:02 PM ronso0 <ronso0@mixxx.org> wrote:
>
> "git rerere forg"<Tab> completes to "git rerere forget=" (should be just "git rerere forget " with a trailing space)

This has been present ever since Nikolai Weibull's git completion was
imported in early 2011.  The comment preceding a call to _values is:

# TODO: This isn’t optimal, as forget get confused.

The attached is a bit of a hack but seems to do the right thing.  Thoughts?

[-- Attachment #2: git-rerere.txt --]
[-- Type: text/plain, Size: 1042 bytes --]

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 14fa01436..b3ed7b5c8 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -4259,14 +4259,14 @@ _git-rerere () {
 
   _arguments -C -S -s $endopt \
     '--rerere-autoupdate[register clean resolutions in index]' \
-    ': :->command' && ret=0
+    ': :->command' \
+    '*: :{ [[ $words[CURRENT-1] = forget ]] && __git_cached_files }' && ret=0
 
   case $state in
     (command)
-      # TODO: This isn't optimal, as forget get confused.
       _values command \
         'clear[reset metadata used by rerere]' \
-        'forget[resets metadata used by rerere for specific conflict]: :__git_cached_files' \
+        'forget[resets metadata used by rerere for specific conflict]' \
         'diff[output diffs for the current state of the resolution]' \
         'status[print paths with conflicts whose merge resolution rerere will record]' \
         'remaining[print paths with conflicts that have not been autoresolved by rerere]' \