From: Clinton Bunch <cdb_zsh@zentaur.org>
To: zsh-workers@zsh.org
Subject: Re: preliminary patch for zsh/random module
Date: Sun, 23 Oct 2022 21:56:19 -0500 [thread overview]
Message-ID: <e837f032-a7cf-920d-8634-66c4fdb73bd5@zentaur.org> (raw)
In-Reply-To: <CAH+w=7Yi0DGkX9qym3aD8B_K8bE1REF9v5aS+xETeYGb-bJ4yw@mail.gmail.com>
On 10/23/2022 9:01 PM, Bart Schaefer wrote:
> On Sat, Oct 22, 2022 at 8:44 PM Clinton Bunch <cdb_zsh@zentaur.org> wrote:
>> It still needs testing on more platforms and additional error-checking
>> as well as documentation, but I was hoping for some feedback on the
>> general ideas.
> Silly nits:
> * Typo in the introductory comment.
I'm pretty sure I've since found and changed all the instances of
Zoltan's name.
> * Indentation is funny, it looks like you may have used tab width
> other than 8 characters, which is the standard for zsh C code. (Or
> just never use tabs to indent.)
Blame notepad. Thunderbird doesn't allow me to attach inline, so I had
to open in Notepad and cut-n-paste. I didn't notice until after I sent
it, how bad the indentation got messed up.
> * There should be spaces on either side of assignment "=" signs. You
> haven't been consistent.
I think I fixed all those. I haven't been consistent because it seems
unnatural to me. Waste of line width.
>
> Aside to -workers: It's probably time to remove Zoltan's name from
> the copyright notices ... or more likely, to specify that the authors
> of new files should replace his name with their own name there.
>
> Actual question: What's the use case for returning or printing a
> block of random bytes? Why does this need to be a builtin?
Mostly because I see constructs like read -k6 -u3 3</dev/urandom, also
it would be nice to initialize an array with random numbers without
having to use a loop to access SRANDOM n times.
>
> Suggestion: Treat SRANDOM like SECONDS, in that you can change the
> type from integer to floating-point. Then maybe the zrandom() math
> function isn't needed?
That would seem confusing to me, and too easy to forget which state you
left it in. zrandom was meant to be a replacement for rand48
>
next prev parent reply other threads:[~2022-10-24 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 3:43 Clinton Bunch
2022-10-24 2:01 ` Bart Schaefer
2022-10-24 2:56 ` Clinton Bunch [this message]
2022-10-24 4:47 ` Bart Schaefer
2022-10-24 13:20 ` Clinton Bunch
2022-10-24 21:15 ` Clinton Bunch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e837f032-a7cf-920d-8634-66c4fdb73bd5@zentaur.org \
--to=cdb_zsh@zentaur.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).