From: Sebastian Gniazdowski <psprint@zdharma.org>
To: "Bart Schaefer" <schaefer@brasslantern.com>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [BUG] In reference to patch 39815, about (z) flag and $( parse error
Date: Fri, 13 Oct 2017 09:53:17 +0200 [thread overview]
Message-ID: <etPan.59e070ed.5eacd522.98a8@zdharma.org> (raw)
In-Reply-To: <CAH+w=7YkdCEZg79001PmZ-oWv18WgzfkD=o15h4Gwz3qhSiJ9g@mail.gmail.com>
On 12 Oct 2017 at 17:26:35, Bart Schaefer (schaefer@brasslantern.com) wrote:
> It'd most likely need to be in bufferwords(), which somehow needs to
> know that the STRING token returned from the lexer is [or not] a
> comment and that therefore it should [or not] ignore the subsequent
> NEWLIN. However, that cascades all the way down into gettok() which
> is where the "#" character is recognized and everything from there up
> to but not including the newline is consumed.
Sounds complicated. Good that parsing problem can be detected by buf+=$'\ntest' and checking if last element returned by (z)/(Z+cn+) is "test".
> So it's not that 5.0.6 was correct, it's that we've swapped one
> problem [that affects more than just (Z:n:)] for another.
I was hoping that the goal of this patch wasn't exactly equal to what it did with (Z+cn+), i.e. that it accidentally changed the flag's behavior.
--
Sebastian Gniazdowski
psprint /at/ zdharma.org
next prev parent reply other threads:[~2017-10-13 7:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:03 Sebastian Gniazdowski
2017-10-10 16:19 ` Sebastian Gniazdowski
2017-10-11 3:49 ` Bart Schaefer
2017-10-11 6:41 ` Peter Stephenson
[not found] ` <etPan.59dd94f1.69ba7f51.98a8@AirmailxGenerated.am>
2017-10-11 8:31 ` Sebastian Gniazdowski
2017-10-11 14:09 ` Sebastian Gniazdowski
2017-10-11 15:07 ` Sebastian Gniazdowski
2017-10-11 17:02 ` Bart Schaefer
2017-10-12 14:54 ` Sebastian Gniazdowski
2017-10-12 15:26 ` Bart Schaefer
2017-10-12 15:50 ` Peter Stephenson
2017-10-13 7:56 ` Bart Schaefer
2017-10-13 9:36 ` Peter Stephenson
2017-10-13 20:55 ` Bart Schaefer
2017-10-14 14:44 ` Sebastian Gniazdowski
2017-10-15 1:53 ` Bart Schaefer
2017-10-15 14:31 ` Sebastian Gniazdowski
2017-10-15 18:09 ` Bart Schaefer
2017-10-15 18:44 ` Daniel Shahaf
2017-10-15 19:59 ` Bart Schaefer
2017-10-17 6:34 ` Sebastian Gniazdowski
2017-10-13 7:53 ` Sebastian Gniazdowski [this message]
2017-10-13 8:04 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.59e070ed.5eacd522.98a8@zdharma.org \
--to=psprint@zdharma.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).