zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [BUG] In reference to patch 39815, about (z) flag and $( parse error
Date: Wed, 11 Oct 2017 10:02:31 -0700	[thread overview]
Message-ID: <171011100231.ZM3821@torch.brasslantern.com> (raw)
In-Reply-To: <etPan.59ddd6c5.c1b5c18.98a8@zdharma.org>

On Oct 11, 10:31am, Sebastian Gniazdowski wrote:
}
} However one test fails on this line.

Hmm, so the problem appears to be that when parsing a comment, we
actually need the NEWLIN token to mark the end of the comment.
When parsing code, we need NEWLIN to be ignored as whitespace and
not tokenized.

That is, in your example the ZSH_AUTOSUGGEST_CLEAR_WIDGETS line is
parsed incorrectly (with my patch) because the line preceding it is
a comment.

So I think the fix for this is going to have to be elsewhere, rather
than in zshlex().


  parent reply	other threads:[~2017-10-11 17:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 15:03 Sebastian Gniazdowski
2017-10-10 16:19 ` Sebastian Gniazdowski
2017-10-11  3:49   ` Bart Schaefer
2017-10-11  6:41     ` Peter Stephenson
     [not found]   ` <etPan.59dd94f1.69ba7f51.98a8@AirmailxGenerated.am>
2017-10-11  8:31     ` Sebastian Gniazdowski
2017-10-11 14:09       ` Sebastian Gniazdowski
2017-10-11 15:07         ` Sebastian Gniazdowski
2017-10-11 17:02       ` Bart Schaefer [this message]
2017-10-12 14:54         ` Sebastian Gniazdowski
2017-10-12 15:26           ` Bart Schaefer
2017-10-12 15:50             ` Peter Stephenson
2017-10-13  7:56               ` Bart Schaefer
2017-10-13  9:36                 ` Peter Stephenson
2017-10-13 20:55                   ` Bart Schaefer
2017-10-14 14:44                     ` Sebastian Gniazdowski
2017-10-15  1:53                       ` Bart Schaefer
2017-10-15 14:31                         ` Sebastian Gniazdowski
2017-10-15 18:09                           ` Bart Schaefer
2017-10-15 18:44                             ` Daniel Shahaf
2017-10-15 19:59                               ` Bart Schaefer
2017-10-17  6:34                             ` Sebastian Gniazdowski
2017-10-13  7:53             ` Sebastian Gniazdowski
2017-10-13  8:04               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171011100231.ZM3821@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).