From: Vincent Lefevre <vincent@vinc17.net>
To: zsh-workers@zsh.org
Subject: Re: HIST_IGNORE_DUPS also ignores command lines that differ by a space between quotes
Date: Tue, 19 Mar 2024 11:57:45 +0100 [thread overview]
Message-ID: <20240319105745.GA4811@qaa.vinc17.org> (raw)
In-Reply-To: <CAH+w=7Z+BJoAc+Rz1Y=6qvHp6UKSF0G+Yxq4_yfWeYmw0acy8Q@mail.gmail.com>
On 2024-03-16 09:00:28 -0700, Bart Schaefer wrote:
> On Fri, Mar 15, 2024 at 5:53 AM Vincent Lefevre <vincent@vinc17.net> wrote:
> > Note that spelling correction, which occurs *before* the line is put
> > in the history, detects quoted text and won't try to correct it.
>
> Spelling correction is actually performed by the lexer, at the same
> time as alias expansion.
>
> > it seems that "quoted status" can be taken into account at that point.
>
> Not without separately storing both the original and lexed state of
> the text.
I don't understand what you mean. The original text does *not*
seem to be used, as what is put in the history is the contents
*after* spelling correction. Moreover, the difference concerning
spaces between word splitting and quoted text is already taking
into account for HIST_REDUCE_BLANKS (which I'm using). I don't
see why it cannot be used for HIST_IGNORE_DUPS too.
qaa:~> echo fil "foo bar"
zsh: correct 'fil' to 'file' [nyae]? y
file foo bar
Recalling the command from the history:
qaa:~> echo file "foo bar"
As you can see, in the history, "fil" has changed to "file" as
corrected, and the 3 spaces after "fil"/"file" have been squashed
to a single one due to HIST_REDUCE_BLANKS.
> Which is in fact done internally, but for hopefully obvious
> reasons is not done in the history file, which (during
> reading/writing) is where most duplicate elimination has to occur.
The history file is not concerned here. This happens with "zsh -f",
where there is no history file:
qaa:~> zsh -f
qaa% setopt HIST_IGNORE_DUPS
qaa% echo "a b"
a b
qaa% echo "a b"
a b
qaa% history
1 setopt HIST_IGNORE_DUPS
2 echo "a b"
BTW, the zshoptions(1) man page correctly says "history list",
not "history file":
HIST_IGNORE_DUPS (-h)
Do not enter command lines into the history list if they are
duplicates of the previous event.
--
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
next prev parent reply other threads:[~2024-03-19 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:38 Vincent Lefevre
2024-03-14 5:13 ` Bart Schaefer
2024-03-15 12:53 ` Vincent Lefevre
2024-03-16 16:00 ` Bart Schaefer
2024-03-19 10:57 ` Vincent Lefevre [this message]
2024-03-19 11:08 ` Mikael Magnusson
2024-03-19 12:34 ` Vincent Lefevre
2024-03-20 17:46 ` Bart Schaefer
2024-03-20 17:48 ` Bart Schaefer
2024-03-20 23:48 ` Vincent Lefevre
2024-03-21 5:22 ` Jun T
2024-03-21 5:36 ` Bart Schaefer
2024-03-21 9:41 ` Jun T
2024-03-21 10:21 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319105745.GA4811@qaa.vinc17.org \
--to=vincent@vinc17.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).