From: Vincent Lefevre <vincent@vinc17.net>
To: zsh-workers@zsh.org
Subject: Re: HIST_IGNORE_DUPS also ignores command lines that differ by a space between quotes
Date: Thu, 21 Mar 2024 00:48:44 +0100 [thread overview]
Message-ID: <20240320234844.GC4811@qaa.vinc17.org> (raw)
In-Reply-To: <CAH+w=7YdYNUOaAZimuc02DvumHwVJdWYEATocc-ku95-DNAZig@mail.gmail.com>
On 2024-03-20 10:46:44 -0700, Bart Schaefer wrote:
> So how about this as a compromise:
>
> diff --git a/Src/hashtable.c b/Src/hashtable.c
> index 75b06c4ad..e1f575a52 100644
> --- a/Src/hashtable.c
> +++ b/Src/hashtable.c
> @@ -1397,6 +1397,14 @@ histstrcmp(const char *str1, const char *str2)
> {
> while (inblank(*str1)) str1++;
> while (inblank(*str2)) str2++;
> +
> + /* If significant whitespace has already been eliminated,
(insignificant)
> + * there is no reason to expend similar effort here. Also,
> + * this is more accurate in cases of quoted whitespace.
> + */
> + if (isset(HISTREDUCEBLANKS))
> + return strcmp(str1, str2);
That's OK for me.
The documentation of HIST_IGNORE_DUPS in the man page should also
be corrected / completed.
FYI, I had noticed this issue while I was doing tests on various
inputs (provided by "echo ... | command"), where I had to test
with different numbers of spaces, as they really matter. And I got
surprised that I didn't find some of my inputs in the history.
--
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
next prev parent reply other threads:[~2024-03-20 23:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:38 Vincent Lefevre
2024-03-14 5:13 ` Bart Schaefer
2024-03-15 12:53 ` Vincent Lefevre
2024-03-16 16:00 ` Bart Schaefer
2024-03-19 10:57 ` Vincent Lefevre
2024-03-19 11:08 ` Mikael Magnusson
2024-03-19 12:34 ` Vincent Lefevre
2024-03-20 17:46 ` Bart Schaefer
2024-03-20 17:48 ` Bart Schaefer
2024-03-20 23:48 ` Vincent Lefevre [this message]
2024-03-21 5:22 ` Jun T
2024-03-21 5:36 ` Bart Schaefer
2024-03-21 9:41 ` Jun T
2024-03-21 10:21 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320234844.GC4811@qaa.vinc17.org \
--to=vincent@vinc17.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).