zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: HIST_IGNORE_DUPS also ignores command lines that differ by a space between quotes
Date: Sat, 16 Mar 2024 09:00:28 -0700	[thread overview]
Message-ID: <CAH+w=7Z+BJoAc+Rz1Y=6qvHp6UKSF0G+Yxq4_yfWeYmw0acy8Q@mail.gmail.com> (raw)
In-Reply-To: <20240315125317.GC3738413@cventin.lip.ens-lyon.fr>

On Fri, Mar 15, 2024 at 5:53 AM Vincent Lefevre <vincent@vinc17.net> wrote:
>
> On 2024-03-13 22:13:09 -0700, Bart Schaefer wrote:
> > Doing a full syntax analysis here would make it a lot more complicated
> > and a lot slower.
>
> I don't think you need to do a full syntax analysis. Isn't this just
> related to tokenization (something like that)?

Tokenization is performed by lexical analysis.

> Note that spelling correction, which occurs *before* the line is put
> in the history, detects quoted text and won't try to correct it.

Spelling correction is actually performed by the lexer, at the same
time as alias expansion.

> it seems that "quoted status" can be taken into account at that point.

Not without separately storing both the original and lexed state of
the text.  Which is in fact done internally, but for hopefully obvious
reasons is not done in the history file, which (during
reading/writing) is where most duplicate elimination has to occur.


  reply	other threads:[~2024-03-16 16:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 12:38 Vincent Lefevre
2024-03-14  5:13 ` Bart Schaefer
2024-03-15 12:53   ` Vincent Lefevre
2024-03-16 16:00     ` Bart Schaefer [this message]
2024-03-19 10:57       ` Vincent Lefevre
2024-03-19 11:08         ` Mikael Magnusson
2024-03-19 12:34           ` Vincent Lefevre
2024-03-20 17:46             ` Bart Schaefer
2024-03-20 17:48               ` Bart Schaefer
2024-03-20 23:48               ` Vincent Lefevre
2024-03-21  5:22               ` Jun T
2024-03-21  5:36                 ` Bart Schaefer
2024-03-21  9:41                   ` Jun T
2024-03-21 10:21                     ` Vincent Lefevre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7Z+BJoAc+Rz1Y=6qvHp6UKSF0G+Yxq4_yfWeYmw0acy8Q@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).