From: Bart Schaefer <schaefer@brasslantern.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: broader support for highlight groups
Date: Fri, 1 Mar 2024 17:39:21 -0800 [thread overview]
Message-ID: <CAH+w=7b3SZG+orcExWjGm0mTGRBJtYLW2obNC1Pe-HcMN6oUXg@mail.gmail.com> (raw)
In-Reply-To: <90949-1709342493.093890@W3fn.AXo8.ESGa>
On Fri, Mar 1, 2024 at 5:21 PM Oliver Kiddle <opk@zsh.org> wrote:
>
> We still lack a way to reset attributes. Rather than %r, which does
> have tenuous conflicts with completion explanations and some obscure
> uses of zformat, I'm tending towards special-casing %H{reset} and/or
> %H{none}.
This would somewhat be in line with the hash tables built by the
"colors" function ... which is both a plus and a minus, because I'm
already tired of explaining that prompts et al. do not use $color
internally.
> And perhaps disabling the feature of allowing left-over
> attributes in the prompt to bleed over into the user's input where those
> attributes came from a highlight group. That feature only exists for
> backward-compatibility and anyone using a new feature like highlight
> groups can also set the default key in zle_highlight. Any opinions?
If you choose to disable bleed-over, please have a look at the way
Functions/Misc/sticky-note applies its background coloring and adjust
if necessary? I've never really spent any time understanding
zle_highlight, and although "vared" has options to set the prompts any
highlighting would (I think?) have to be done in the line-init and
line-finish widgets if the prompts can't bleed?
next prev parent reply other threads:[~2024-03-02 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:21 Oliver Kiddle
2024-03-02 1:39 ` Bart Schaefer [this message]
2024-03-30 1:06 ` sticky-note and prompt color leftovers (Re: PATCH: broader support for highlight groups) Oliver Kiddle
2024-03-30 3:16 ` Bart Schaefer
2024-03-30 12:23 ` Oliver Kiddle
2024-03-30 19:14 ` Bart Schaefer
2024-03-02 7:57 ` PATCH: broader support for highlight groups Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7b3SZG+orcExWjGm0mTGRBJtYLW2obNC1Pe-HcMN6oUXg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=opk@zsh.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).