From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: broader support for highlight groups
Date: Sat, 2 Mar 2024 08:57:53 +0100 [thread overview]
Message-ID: <CAHYJk3R1XJCuz9WZe-TJBFrFs0f+FcyDaRdaGFGX9BL5FYC6vw@mail.gmail.com> (raw)
In-Reply-To: <90949-1709342493.093890@W3fn.AXo8.ESGa>
On 3/2/24, Oliver Kiddle <opk@zsh.org> wrote:
> This broadens the support for %H to completion explanation strings
> (with and without complist) and WATCHFMT, both of which already support
> %B/%S/%U/%F/%K. This also affects the list-prompt style as a
> side-effect.
>
> Completion for prompt strings also gains support for %H.
>
> The return value from parsehighlight() has been changed to go one
> past the end character because that's now convenient for more of the
> callers than leaving it on the end character. The one change of int to
> size_t in watch.c is to silence a (-Wextra) compiler warning.
>
> We still lack a way to reset attributes. Rather than %r, which does
> have tenuous conflicts with completion explanations and some obscure
> uses of zformat, I'm tending towards special-casing %H{reset} and/or
> %H{none}. And perhaps disabling the feature of allowing left-over
> attributes in the prompt to bleed over into the user's input where those
> attributes came from a highlight group. That feature only exists for
> backward-compatibility and anyone using a new feature like highlight
> groups can also set the default key in zle_highlight. Any opinions?
What about just %H without any arguments to reset?
--
Mikael Magnusson
prev parent reply other threads:[~2024-03-02 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:21 Oliver Kiddle
2024-03-02 1:39 ` Bart Schaefer
2024-03-30 1:06 ` sticky-note and prompt color leftovers (Re: PATCH: broader support for highlight groups) Oliver Kiddle
2024-03-30 3:16 ` Bart Schaefer
2024-03-30 12:23 ` Oliver Kiddle
2024-03-30 19:14 ` Bart Schaefer
2024-03-02 7:57 ` Mikael Magnusson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3R1XJCuz9WZe-TJBFrFs0f+FcyDaRdaGFGX9BL5FYC6vw@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=opk@zsh.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).