From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: sticky-note and prompt color leftovers (Re: PATCH: broader support for highlight groups)
Date: Fri, 29 Mar 2024 20:16:54 -0700 [thread overview]
Message-ID: <CAH+w=7bOrAn9s+sk-R_-aJZvpRyxmWFDejzuu6K5Zree4Xx2og@mail.gmail.com> (raw)
In-Reply-To: <65188-1711760801.491883@dElB.g8CB.0-rg>
On Fri, Mar 29, 2024 at 6:06 PM Oliver Kiddle <opk@zsh.org> wrote:
>
> Firstly, on the subject of sticky-note, had you intended to commit 47563
> and/or 48773?
No, but I was planning to commit 52314 if any feedback were provided
(which none has been, so far). So please have a look a that, if you
don't mind.
> sticky-note uses raw escape sequences so it remains as broken as before.
Indeed, the ideal thing would be rewriting it to use highlight
instead. (Not that I'm asking you to do more than provide pointers.)
> It doesn't need much more than to precede the vared with, e.g.
> local zle_highlight=( default:fg=black,bg=yellow )
OK. What about effects like underlining or blinking?
> I know that when I worked on this a year ago, I had it in mind to add
> an additional key for zle_highlight which is used for line clearing
> allowing a background for the area on the right that doesn't contain
> text. I can't remember whether or not it was discussed. Any thoughts on
> the name - viewport, buffer, field?
I don't recall discussion either. How (if at all) does the PREDISPLAY
/ POSTDISPLAY text fit into this? Would the fallback case be to match
the bg= color or to use the terminal default background?
next prev parent reply other threads:[~2024-03-30 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:21 PATCH: broader support for highlight groups Oliver Kiddle
2024-03-02 1:39 ` Bart Schaefer
2024-03-30 1:06 ` sticky-note and prompt color leftovers (Re: PATCH: broader support for highlight groups) Oliver Kiddle
2024-03-30 3:16 ` Bart Schaefer [this message]
2024-03-30 12:23 ` Oliver Kiddle
2024-03-30 19:14 ` Bart Schaefer
2024-03-02 7:57 ` PATCH: broader support for highlight groups Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bOrAn9s+sk-R_-aJZvpRyxmWFDejzuu6K5Zree4Xx2og@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).