[9fans] vx32 @ FreeBSD: 9vx/a/chan.c:1220: error: conflicting types for 'memrchr'

[9fans] vx32 @ FreeBSD: 9vx/a/chan.c:1220: error: conflicting types for 'memrchr'

[Nikolai Saoukh]

$ uname -a
FreeBSD NetFaker 7.0-STABLE FreeBSD 7.0-STABLE #13: Wed Jul  2
15:04:57 MSD 2008     nms@NetFaker:/usr/obj/usr/src/sys/NETFAKER  i386
$ gmake
gcc -g -O3 -MD -std=gnu99 -I.  -I. -I9vx -I9vx/a -Wall
-Wno-missing-braces -c -o 9vx/a/chan.o 9vx/a/chan.c
9vx/a/chan.c:1220: error: conflicting types for 'memrchr'
/usr/include/string.h:62: error: previous declaration of 'memrchr' was
here {void    *memrchr(const void *, int, size_t) __pure;}

Re: [9fans] vx32 @ FreeBSD: 9vx/a/chan.c:1220: error: conflicting types for 'memrchr'

[Martin Neubauer]

FreeBSD added memrchr to its libc a couple of weeks ago. The system one uses
size_t for the len argument; the 9vx one long. Changing that to unsigned
long probably would make the compiler happy but would most likely choke the
linker up. I chickened out and just commented out the definition in chan.c.
Another approach could be to rename memrchr to memrchr9 or the like. By the
way, drawterm and inferno are affected by that, too.

I hope that gets you going,
	MArtin

* Nikolai Saoukh (nms+9fans@otdel-1.org) wrote:
> $ uname -a
> FreeBSD NetFaker 7.0-STABLE FreeBSD 7.0-STABLE #13: Wed Jul  2
> 15:04:57 MSD 2008     nms@NetFaker:/usr/obj/usr/src/sys/NETFAKER  i386
> $ gmake
> gcc -g -O3 -MD -std=gnu99 -I.  -I. -I9vx -I9vx/a -Wall
> -Wno-missing-braces -c -o 9vx/a/chan.o 9vx/a/chan.c
> 9vx/a/chan.c:1220: error: conflicting types for 'memrchr'
> /usr/include/string.h:62: error: previous declaration of 'memrchr' was
> here {void    *memrchr(const void *, int, size_t) __pure;}

Re: [9fans] vx32 @ FreeBSD: 9vx/a/chan.c:1220: error: conflicting types for 'memrchr'

[Nikolai Saoukh]

> FreeBSD added memrchr to its libc a couple of weeks ago. The system one uses
> size_t for the len argument; the 9vx one long. Changing that to unsigned
> long probably would make the compiler happy but would most likely choke the
> linker up. I chickened out and just commented out the definition in chan.c.
> Another approach could be to rename memrchr to memrchr9 or the like. By the
> way, drawterm and inferno are affected by that, too.

This function is used exactly one time in the same file (~30 lines
below). What kind (version) of OS does not have memrchr?

Re: [9fans] vx32 @ FreeBSD: 9vx/a/chan.c:1220: error: conflicting types for 'memrchr'

[Martin Neubauer]

Speaking of FreeBSD, I'd guess that all versions up to 7.0-RELEASE (and some
time beyond) don't have it. As the surrounding code seems to be more or less
shared with drawterm and inferno that could make for a large share of the
user base (on FreeBSD.) Therefore I think the rename would be the cleanest
solution. In some way that reminds me of the situation described in ``#ifdef
considered harmful.''

* Nikolai Saoukh (nms+9fans@otdel-1.org) wrote:
> This function is used exactly one time in the same file (~30 lines
> below). What kind (version) of OS does not have memrchr?