[9fans] How to submit a patch for 9fans.net/go/plan9/client?

[9fans] How to submit a patch for 9fans.net/go/plan9/client?

[Mark Bucciarelli]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi,

I'd like to fix the XXX at
https://github.com/9fans/go/blob/master/plan9/client/conn.go#L41-L46.  Per
the man page, version should send a tag of NOTAG, and it currently sends a
1.  Making it so, and then replacing the rpc() call with c.write followed
by a c.read should do the trick.

How do I submit a patch?  I see forks on github, but no one merging back to
9fans.  Is there a codereview link somewhere I should use?  Or just a
normal github pull request.

Thanks,

Mark

[-- Attachment #2: Type: text/html, Size: 689 bytes --]

Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?

[Skip Tavakkolian]

i would guess that at least rsc and rob review pull requests; a pull
request would be the best bet.

> Hi,
>
> I'd like to fix the XXX at
> https://github.com/9fans/go/blob/master/plan9/client/conn.go#L41-L46.  Per
> the man page, version should send a tag of NOTAG, and it currently sends a
> 1.  Making it so, and then replacing the rpc() call with c.write followed
> by a c.read should do the trick.
>
> How do I submit a patch?  I see forks on github, but no one merging back to
> 9fans.  Is there a codereview link somewhere I should use?  Or just a
> normal github pull request.
>
> Thanks,
>
> Mark

Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?

[lucio]

> i would guess that at least rsc and rob review pull requests; a pull
> request would be the best bet.

The Go Team is explicit about not accepting pull requests, although I
have no idea how that actually works (I have every intention to read
the O'Reilly GIT book, but none too soon).

I have sent small tweaks to Rob in the recent past, though, so that is
a perfectly fine approach.  David (0intro) and others will also be
happy, I'm sure, to pass patches on if Mark is not willing to go
through the code review procedure.

Lucio.

Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?

[Jeremy Jackins]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

> The Go Team is explicit about not accepting pull requests

This repo is not a part of the Go project, though.

On Wed, 9 Sep 2015 at 13:29 <lucio@proxima.alt.za> wrote:

> > i would guess that at least rsc and rob review pull requests; a pull
> > request would be the best bet.
>
> The Go Team is explicit about not accepting pull requests, although I
> have no idea how that actually works (I have every intention to read
> the O'Reilly GIT book, but none too soon).
>
> I have sent small tweaks to Rob in the recent past, though, so that is
> a perfectly fine approach.  David (0intro) and others will also be
> happy, I'm sure, to pass patches on if Mark is not willing to go
> through the code review procedure.
>
> Lucio.
>
>
>

[-- Attachment #2: Type: text/html, Size: 1242 bytes --]

Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?

[lucio]

> This repo is not a part of the Go project, though.

Oh, I guess I should have been more attentive.

Apologies to all involved.

Lucio.

Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?

[Aram Hăvărneanu]

On Wed, Sep 9, 2015 at 9:52 AM, Jeremy Jackins <jeremyjackins@gmail.com> wrote:
> This repo is not a part of the Go project, though.

It uses the same procedure, though.

See plan9port's codereview(1).

-- 
Aram Hăvărneanu

Re: [9fans] How to submit a patch for 9fans.net/go/plan9/client?

[Mark Bucciarelli]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

> See plan9port's codereview(1).

Thanks to all.

(BTW, I've recently learned about p9 protocol and since then, I see
filesystem everywhere.  :)  I'm currently working on a file system for
virtual users in Go.  The paper on the caching worm drive was amazing.
Back to lurking.)

On Wed, Sep 9, 2015 at 5:59 AM, Aram Hăvărneanu <aram.h@mgk.ro> wrote:

> On Wed, Sep 9, 2015 at 9:52 AM, Jeremy Jackins <jeremyjackins@gmail.com>
> wrote:
> > This repo is not a part of the Go project, though.
>
> It uses the same procedure, though.
>
> See plan9port's codereview(1).
>
> --
> Aram Hăvărneanu
>
>

[-- Attachment #2: Type: text/html, Size: 1389 bytes --]