9front - general discussion about 9front
 help / color / mirror / Atom feed
* [9front] [patch] Merging echoline's drawterm forks (fbdev and android)  into drawterm
@ 2021-08-14  3:59 Lorenzo Bivens
  2021-08-14 12:19 ` sirjofri
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Lorenzo Bivens @ 2021-08-14  3:59 UTC (permalink / raw)
  To: 9front

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Dear 9front,

I found a couple of forks (thank you echoline) of drawterm that include additions that for sure will profit the community. I've carefully merged them into our front branch and it would seem nothing was broken. 

I am aware of another fork by sirjofri that introduces improvements to the android implementation, but I haven't had a chance yet to make the merge.

It would be great if we could make this part of our front branch (left to the community to decide)
The original forks are 
https://github.com/echoline/drawterm-android
https://github.com/echoline/drawterm-fbdev

Best,
Izaki

[-- Attachment #2: 0001-Merging-echoline-s-android-and-fbdev-forks.patch --]
[-- Type: application/octet-stream, Size: 231890 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android)  into drawterm
  2021-08-14  3:59 [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm Lorenzo Bivens
@ 2021-08-14 12:19 ` sirjofri
  2021-08-14 17:30 ` cinap_lenrek
  2021-08-15 16:29 ` Amavect
  2 siblings, 0 replies; 11+ messages in thread
From: sirjofri @ 2021-08-14 12:19 UTC (permalink / raw)
  To: 9front


14.08.2021 05:59:35 Lorenzo Bivens <izaki@belaska.us>:
> I am aware of another fork by sirjofri that introduces improvements to 
> the android implementation, but I haven't had a chance yet to make the 
> merge.

My changes are mostly cosmetic and only relevant for the android 
implementation. It basically only adds true mouse support (for USB mice) 
and tried to adjust the mouse offset (which still isn't perfect, but at 
least the offset is the same across the whole screen now). I made no 
changes to the underlying drawterm stuff.

That said, I have not added support for mouse chording, although this 
might be very trivial to do.

sirjofri

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android)  into drawterm
  2021-08-14  3:59 [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm Lorenzo Bivens
  2021-08-14 12:19 ` sirjofri
@ 2021-08-14 17:30 ` cinap_lenrek
  2021-08-15 16:29 ` Amavect
  2 siblings, 0 replies; 11+ messages in thread
From: cinap_lenrek @ 2021-08-14 17:30 UTC (permalink / raw)
  To: 9front

sounds good, but the patch is full of errors... like adding README.bak files... randomly
changing permissions on libc files... adding .keep files???

just clean it up, make sure it applies cleanly and i can apply it to the repo.

--
cinap

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android)  into drawterm
  2021-08-14  3:59 [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm Lorenzo Bivens
  2021-08-14 12:19 ` sirjofri
  2021-08-14 17:30 ` cinap_lenrek
@ 2021-08-15 16:29 ` Amavect
  2021-08-16 15:49   ` Lorenzo Bivens
  2 siblings, 1 reply; 11+ messages in thread
From: Amavect @ 2021-08-15 16:29 UTC (permalink / raw)
  To: 9front

On Sat, 14 Aug 2021 03:59:35 +0000
Lorenzo Bivens <izaki@belaska.us> wrote:

> Dear 9front,
> 
> I found a couple of forks (thank you echoline) of drawterm that
> include additions that for sure will profit the community. I've
> carefully merged them into our front branch and it would seem nothing
> was broken. 
> 
> I am aware of another fork by sirjofri that introduces improvements
> to the android implementation, but I haven't had a chance yet to make
> the merge.
> 
> It would be great if we could make this part of our front branch
> (left to the community to decide) The original forks are 
> https://github.com/echoline/drawterm-android
> https://github.com/echoline/drawterm-fbdev
> 
> Best,
> Izaki

I don't know much about building for Android, but it sounds cool.
It would be awesome if it could be put on F-Droid.

Thanks,
Amavect

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android)  into drawterm
  2021-08-15 16:29 ` Amavect
@ 2021-08-16 15:49   ` Lorenzo Bivens
  2021-08-16 15:59     ` hiro
  0 siblings, 1 reply; 11+ messages in thread
From: Lorenzo Bivens @ 2021-08-16 15:49 UTC (permalink / raw)
  To: 9front

@cinap, I've cleaned up my act... errr... my patch. git/import works with it. 
Garbage was definitely my fault, but I specially blame Windows for not ending lines like everyone else.
Please let me know if you find any additional defect

@Amavect, drawterm on f-droid would be awesome. I'll look into it after I merge in Sirjofri's changes

Cheerios,
izaki

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm
  2021-08-16 15:49   ` Lorenzo Bivens
@ 2021-08-16 15:59     ` hiro
  2021-08-16 19:14       ` Lorenzo Bivens
  0 siblings, 1 reply; 11+ messages in thread
From: hiro @ 2021-08-16 15:59 UTC (permalink / raw)
  To: 9front

i don't think you left a patch or link in your last message

On 8/16/21, Lorenzo Bivens <izaki@belaska.us> wrote:
> @cinap, I've cleaned up my act... errr... my patch. git/import works with
> it.
> Garbage was definitely my fault, but I specially blame Windows for not
> ending lines like everyone else.
> Please let me know if you find any additional defect
>
> @Amavect, drawterm on f-droid would be awesome. I'll look into it after I
> merge in Sirjofri's changes
>
> Cheerios,
> izaki

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm
  2021-08-16 15:59     ` hiro
@ 2021-08-16 19:14       ` Lorenzo Bivens
  2021-08-18  3:31         ` Lorenzo Bivens
  0 siblings, 1 reply; 11+ messages in thread
From: Lorenzo Bivens @ 2021-08-16 19:14 UTC (permalink / raw)
  To: 9front

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]

> i don't think you left a patch or link in your last message

*Picard face covering maneuver*

How about now?

[-- Attachment #2: 0001-Merging-echoline-s-android-and-fbdev-forks.patch --]
[-- Type: application/octet-stream, Size: 229575 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm
  2021-08-16 19:14       ` Lorenzo Bivens
@ 2021-08-18  3:31         ` Lorenzo Bivens
  2021-08-18 13:16           ` cinap_lenrek
  0 siblings, 1 reply; 11+ messages in thread
From: Lorenzo Bivens @ 2021-08-18  3:31 UTC (permalink / raw)
  To: 9front

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

Bump.
Is this patch ok?

Thanks,
izaki

[-- Attachment #2: 0001-Merging-echoline-s-android-and-fbdev-forks.patch --]
[-- Type: application/octet-stream, Size: 229575 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm
  2021-08-18  3:31         ` Lorenzo Bivens
@ 2021-08-18 13:16           ` cinap_lenrek
  2021-08-18 19:24             ` Lorenzo Bivens
  0 siblings, 1 reply; 11+ messages in thread
From: cinap_lenrek @ 2021-08-18 13:16 UTC (permalink / raw)
  To: 9front

no, it still contains pointless addition of libc/getpid.c.

--
cinap

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm
  2021-08-18 13:16           ` cinap_lenrek
@ 2021-08-18 19:24             ` Lorenzo Bivens
  2021-08-19 13:18               ` cinap_lenrek
  0 siblings, 1 reply; 11+ messages in thread
From: Lorenzo Bivens @ 2021-08-18 19:24 UTC (permalink / raw)
  To: 9front

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

@cinap, indeed, getpid does nothing
I've removed it from the patch
thanks,
izaki

________________________________________
From: cinap_lenrek@felloff.net <cinap_lenrek@felloff.net>
Sent: Wednesday, August 18, 2021 6:16 AM
To: 9front@9front.org
Subject: Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm

no, it still contains pointless addition of libc/getpid.c.

--
cinap

[-- Attachment #2: 0001-Merging-echoline-s-android-and-fbdev-forks.patch --]
[-- Type: application/octet-stream, Size: 229143 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm
  2021-08-18 19:24             ` Lorenzo Bivens
@ 2021-08-19 13:18               ` cinap_lenrek
  0 siblings, 0 replies; 11+ messages in thread
From: cinap_lenrek @ 2021-08-19 13:18 UTC (permalink / raw)
  To: 9front

applied! thanks!

--
cinap

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-08-19 13:24 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-14  3:59 [9front] [patch] Merging echoline's drawterm forks (fbdev and android) into drawterm Lorenzo Bivens
2021-08-14 12:19 ` sirjofri
2021-08-14 17:30 ` cinap_lenrek
2021-08-15 16:29 ` Amavect
2021-08-16 15:49   ` Lorenzo Bivens
2021-08-16 15:59     ` hiro
2021-08-16 19:14       ` Lorenzo Bivens
2021-08-18  3:31         ` Lorenzo Bivens
2021-08-18 13:16           ` cinap_lenrek
2021-08-18 19:24             ` Lorenzo Bivens
2021-08-19 13:18               ` cinap_lenrek

9front - general discussion about 9front

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/9front

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 9front 9front/ https://inbox.vuxu.org/9front \
		9front@9front.org
	public-inbox-index 9front

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.9front


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git