9front - general discussion about 9front
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] libsec: various tls changes
Date: Wed, 16 Jun 2021 16:02:10 +0200	[thread overview]
Message-ID: <1F0E89C0DA556E9265991DE6E86C77D4@felloff.net> (raw)
In-Reply-To: <CABO6shfysZBr2-ai4RumchGDWanrcxGMm-ANW=FKXEP8fXGQ9g@mail.gmail.com>

> wdym? tlsServerExtensions always returns nil,
> (well, for now as we don't send any extensions.)
> so, we don't need to free ext.

hm... that sounds like a trap waiting to happen.

if we never produce any extension response, maybe
it would be better to just get rid of it for now
and return a error status instead?

also, the naming would need to change. as this
function actually never *produces* server
extensions and instead *processes* the client
extensions... what about something like:

if(!okClientExtensions(c, m.u.clientHello.extensions))
	goto Err;

once we need to produce server extensions we
can add the function back... and we can place
it somewhere near/before the sending the
server hello so error handling is less complicated.

--
cinap

  reply	other threads:[~2021-06-16 14:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 15:06 kemal
2021-06-12 13:15 ` cinap_lenrek
2021-06-12 19:54   ` kemal
2021-06-14 18:26     ` cinap_lenrek
2021-06-14 20:27       ` kemal
2021-06-16  9:48         ` cinap_lenrek
2021-06-16 11:59           ` kemal
2021-06-16 14:02             ` cinap_lenrek [this message]
2021-06-18 18:51               ` kemal
2021-06-18 19:13                 ` kemal
2021-06-19 14:20                   ` cinap_lenrek
2021-06-20 14:56                 ` cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1F0E89C0DA556E9265991DE6E86C77D4@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).