From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] libsec: various tls changes
Date: Sun, 20 Jun 2021 16:56:24 +0200 [thread overview]
Message-ID: <7E7CCAAABA337DF1906098CC2567EA47@felloff.net> (raw)
In-Reply-To: <CABO6shfTEKNjFdx4O1e_tU-XPn+bu7J=tE6GZF_7xXPDthRyZA@mail.gmail.com>
> also, after a bit of diving in the rfcs i found out that
> the x25519 rfc specifies an optional step that if the
> shared secret turned out to be all zeroes, abort.
> rfc 8422 (tls ecc rfc) says that this MUST be done.
yeah, good catch. this is also what boringssl does.
> i was unsure if i should have added that check to
> curve25519_finish, as it would break source compatibility,
> so i added it to tlsSecECDHE*.
yeah, but this function is used rarely (only ssh and tlshand
right now) so it is not a big deal to change the return value
from void to int and fix the callers.
i think it is better todo it internally, especially as the caller
might forget todo the cehck in a timing-safe way.
pushed a fix for both plan9front and drawterm.
--
cinap
prev parent reply other threads:[~2021-06-20 22:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 15:06 kemal
2021-06-12 13:15 ` cinap_lenrek
2021-06-12 19:54 ` kemal
2021-06-14 18:26 ` cinap_lenrek
2021-06-14 20:27 ` kemal
2021-06-16 9:48 ` cinap_lenrek
2021-06-16 11:59 ` kemal
2021-06-16 14:02 ` cinap_lenrek
2021-06-18 18:51 ` kemal
2021-06-18 19:13 ` kemal
2021-06-19 14:20 ` cinap_lenrek
2021-06-20 14:56 ` cinap_lenrek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E7CCAAABA337DF1906098CC2567EA47@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).