From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] libsec: various tls changes
Date: Sat, 12 Jun 2021 15:15:02 +0200 [thread overview]
Message-ID: <867EF01C41DA1F5C5F16C87137F0B4D8@felloff.net> (raw)
In-Reply-To: <CABO6shcYyjW57Avu2BKqR6tDZ2LNFMA+-JVsXv1ey=zqtwrRag@mail.gmail.com>
i think theres a problem with the curve negotiation.
the new tlsServerExtensions() function can leave c->sec->nc unset.
and later, tlsServer2() has this change:
- Namedcurve *nc = &namedcurves[0]; /* secp256r1 */
-
m.tag = HServerKeyExchange;
- m.u.serverKeyExchange.curve = nc->tlsid;
- m.u.serverKeyExchange.dh_parameters = tlsSecECDHEs1(c->sec, nc);
+ m.u.serverKeyExchange.curve = c->sec->nc->tlsid;
+ m.u.serverKeyExchange.dh_parameters = tlsSecECDHEs1(c->sec);
maybe we can make the code more explicit about this? it is hard to
see that it is supposed to modify.
otherwise the changes seem reasonable. it is just alot of changes all
at once. maybe you can submit the prf changes and the unixtime changes
separately?
--
cinap
next prev parent reply other threads:[~2021-06-12 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 15:06 kemal
2021-06-12 13:15 ` cinap_lenrek [this message]
2021-06-12 19:54 ` kemal
2021-06-14 18:26 ` cinap_lenrek
2021-06-14 20:27 ` kemal
2021-06-16 9:48 ` cinap_lenrek
2021-06-16 11:59 ` kemal
2021-06-16 14:02 ` cinap_lenrek
2021-06-18 18:51 ` kemal
2021-06-18 19:13 ` kemal
2021-06-19 14:20 ` cinap_lenrek
2021-06-20 14:56 ` cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867EF01C41DA1F5C5F16C87137F0B4D8@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).