Re: [9front] [Bug] Mail fails to send attachments

[ori@eigenstate.org]

Quoth sirjofri <sirjofri+ml-9front@sirjofri.de>:
> 
> 19.02.2021 20:56:00 theinicke@bss-wf.de:
> > Today I have noticed that since the rewrite Mail fails to send 
> > attachments.
> > That is if one includes an "Attach: /some/file" line and posts it,
> > (if file exists) marshal suicides like so: 66286: marshal 66286: sys: 
> > write on closed pipe pc=0x25e04
> > leaving us with a sent mail without the attachments.
> >
> > I have not been able to track down the cause yet.
> > Have reproduced it on a clean install updated to latest HEAD
> > to make sure it is not caused by any of my modifications.
> > Here are the symptoms:
> >
> > If in /sys/src/cmd/upas/marshal/marshal.c:421 attachment function is 
> > called, then
> > in /sys/src/cmd/upas/marshal/marshal.c:430 the error occurs.
> 
> Same here. The same happens when using Include: instead of Attach. Ori is 
> unable to reproduce this, afaik. Using marshal -8 directly works fine 
> btw.
> 
> sirjofri
> 

I don't know why marshal -8 would work, when
Mail wouldn't. We just invoke:

	upas/marshal -8 -S outgoing

The pipe being closed is talking to upas/send,
which is likely dying or exiting early. This
may help capture it:

diff -r 39b061370f36 sys/src/cmd/upas/marshal/marshal.c
--- a/sys/src/cmd/upas/marshal/marshal.c	Wed Feb 17 11:20:13 2021 +0100
+++ b/sys/src/cmd/upas/marshal/marshal.c	Fri Feb 19 13:08:55 2021 -0800
@@ -1172,6 +1172,7 @@
 
 	err = nil;
 	while((w = wait()) != nil){
+		fprint(2, "%d: %s\n", w->pid, w->msg);
 		if(w->pid == pid || w->pid == pgppid)
 			if(w->msg[0] != 0)
 				err = estrdup(w->msg);


If you have dtracy enabled, it may be possible
to snoop the exit status, which could help
get an idea of what's going on. Don't see a
great way to get the process name, so it'll
take some guesswork:

	dtracy 'sys:exits:entry if(arg0 != 0) {
		print probe, pid, (string)arg0
	}'