9front - general discussion about 9front
 help / color / mirror / Atom feed
* [9front] drawterm convM2A should return -m if form1M2B()<0 ?
@ 2022-03-26  2:04 Xiao-Yong Jin
  2022-03-26 22:01 ` cinap_lenrek
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao-Yong Jin @ 2022-03-26  2:04 UTC (permalink / raw)
  To: 9front

Do I understand it correctly?

diff --git a/libauthsrv/convM2A.c b/libauthsrv/convM2A.c
index 0da7865..5f7bd2f 100644
--- a/libauthsrv/convM2A.c
+++ b/libauthsrv/convM2A.c
@@ -23,7 +23,7 @@ convM2A(char *ap, int n, Authenticator *f, Ticket *t)
 			return -m;
 		memmove(buf, ap, m);
 		if(form1M2B((char*)buf, m, t->key) < 0)
-			return m;
+			return -m;
 	}
 	p = buf;
 	f->num = *p++;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [9front] drawterm convM2A should return -m if form1M2B()<0 ?
  2022-03-26  2:04 [9front] drawterm convM2A should return -m if form1M2B()<0 ? Xiao-Yong Jin
@ 2022-03-26 22:01 ` cinap_lenrek
  0 siblings, 0 replies; 2+ messages in thread
From: cinap_lenrek @ 2022-03-26 22:01 UTC (permalink / raw)
  To: 9front

no.

negative means the amount of bytes expected.

in this case, we got the right amount of bytes,
but authentication fails, so we wont put the
message type and the caller will reject the
authenticator.

--
cinap

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-26 22:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-26  2:04 [9front] drawterm convM2A should return -m if form1M2B()<0 ? Xiao-Yong Jin
2022-03-26 22:01 ` cinap_lenrek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).