* [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
@ 2023-05-25 3:31 Stanley Lieber
2023-05-25 3:33 ` Stanley Lieber
2023-05-25 11:42 ` mia soweli
0 siblings, 2 replies; 13+ messages in thread
From: Stanley Lieber @ 2023-05-25 3:31 UTC (permalink / raw)
To: 9front
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 20230524_233032.jpg --]
[-- Type: image/jpeg, Size: 1551654 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 3:31 [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt Stanley Lieber
@ 2023-05-25 3:33 ` Stanley Lieber
2023-05-25 4:47 ` unobe
2023-05-25 11:42 ` mia soweli
1 sibling, 1 reply; 13+ messages in thread
From: Stanley Lieber @ 2023-05-25 3:33 UTC (permalink / raw)
To: 9front
On May 24, 2023 11:31:33 PM EDT, Stanley Lieber <sl@stanleylieber.com> wrote:
>
http://plan9.stanleylieber.com/hardware/thinkpad/x1/yoga/g3/sysinfo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 3:33 ` Stanley Lieber
@ 2023-05-25 4:47 ` unobe
2023-05-25 5:05 ` Stanley Lieber
0 siblings, 1 reply; 13+ messages in thread
From: unobe @ 2023-05-25 4:47 UTC (permalink / raw)
To: 9front
Quoth Stanley Lieber <sl@stanleylieber.com>:
> On May 24, 2023 11:31:33 PM EDT, Stanley Lieber <sl@stanleylieber.com> wrote:
> >
> http://plan9.stanleylieber.com/hardware/thinkpad/x1/yoga/g3/sysinfo
So the latest code (do you have a specific commit to reference) works
fine, until you try to fshalt?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 4:47 ` unobe
@ 2023-05-25 5:05 ` Stanley Lieber
0 siblings, 0 replies; 13+ messages in thread
From: Stanley Lieber @ 2023-05-25 5:05 UTC (permalink / raw)
To: 9front
On May 25, 2023 12:47:45 AM EDT, unobe@cpan.org wrote:
>Quoth Stanley Lieber <sl@stanleylieber.com>:
>> On May 24, 2023 11:31:33 PM EDT, Stanley Lieber <sl@stanleylieber.com> wrote:
>> >
>> http://plan9.stanleylieber.com/hardware/thinkpad/x1/yoga/g3/sysinfo
>
>So the latest code (do you have a specific commit to reference) works
>fine, until you try to fshalt?
>
>
yes, everything is fine until fshalt. the crash happens on every fshalt.
i did sysupdate, rebuilt the system, installed the kernel, and tested shortly before sending the original mail. no new commits since then.
sl
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 3:31 [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt Stanley Lieber
2023-05-25 3:33 ` Stanley Lieber
@ 2023-05-25 11:42 ` mia soweli
2023-05-25 13:51 ` Stanley Lieber
1 sibling, 1 reply; 13+ messages in thread
From: mia soweli @ 2023-05-25 11:42 UTC (permalink / raw)
To: 9front
the stack trace attached seems to have been truncated,
and it's not enough to see what's being freed.
could you upload it somewhere so i can get the full trace?
thanks
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 11:42 ` mia soweli
@ 2023-05-25 13:51 ` Stanley Lieber
2023-05-25 15:16 ` Sigrid Solveig Haflínudóttir
0 siblings, 1 reply; 13+ messages in thread
From: Stanley Lieber @ 2023-05-25 13:51 UTC (permalink / raw)
To: 9front
On May 25, 2023 7:42:12 AM EDT, mia soweli <inbox@tachibana-labs.org> wrote:
>the stack trace attached seems to have been truncated,
>and it's not enough to see what's being freed.
>
>could you upload it somewhere so i can get the full trace?
>
>thanks
>
>
http://img.stanleylieber.com/src/23771/img/1685022656.jpg
sl
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 13:51 ` Stanley Lieber
@ 2023-05-25 15:16 ` Sigrid Solveig Haflínudóttir
2023-05-26 0:50 ` sl
0 siblings, 1 reply; 13+ messages in thread
From: Sigrid Solveig Haflínudóttir @ 2023-05-25 15:16 UTC (permalink / raw)
To: 9front
the bug is in sdram.c, it uses xalloc for sddev allocation, but
devsd.c calls free on it. should be an easy fix I guess.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-25 15:16 ` Sigrid Solveig Haflínudóttir
@ 2023-05-26 0:50 ` sl
2023-05-26 1:06 ` Sigrid Solveig Haflínudóttir
0 siblings, 1 reply; 13+ messages in thread
From: sl @ 2023-05-26 0:50 UTC (permalink / raw)
To: 9front
> the bug is in sdram.c, it uses xalloc for sddev allocation, but
> devsd.c calls free on it. should be an easy fix I guess.
i wonder why this never triggered until just now. i've been running
9front on this machine all year.
sl
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-26 0:50 ` sl
@ 2023-05-26 1:06 ` Sigrid Solveig Haflínudóttir
2023-05-26 2:00 ` sl
0 siblings, 1 reply; 13+ messages in thread
From: Sigrid Solveig Haflínudóttir @ 2023-05-26 1:06 UTC (permalink / raw)
To: 9front
It's because I added nvme shutdown via fshalt, and apparently shutting down *ram* disks uncovered this bug. Because sdram seems to be only present on pc and pc64 (read: none that I have here) I haven't noticed it before pushing my change. I think you can just replace xalloc back with malloc in sdram.c.
Sorry.
On May 26, 2023 2:50:16 AM GMT+02:00, sl@stanleylieber.com wrote:
>> the bug is in sdram.c, it uses xalloc for sddev allocation, but
>> devsd.c calls free on it. should be an easy fix I guess.
>
>i wonder why this never triggered until just now. i've been running
>9front on this machine all year.
>
>sl
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt
2023-05-26 1:06 ` Sigrid Solveig Haflínudóttir
@ 2023-05-26 2:00 ` sl
2023-05-26 15:36 ` Tobias Heinicke
0 siblings, 1 reply; 13+ messages in thread
From: sl @ 2023-05-26 2:00 UTC (permalink / raw)
To: 9front
> It's because I added nvme shutdown via fshalt, and apparently shutting
> down *ram* disks uncovered this bug. Because sdram seems to be only
> present on pc and pc64 (read: none that I have here) I haven't noticed
> it before pushing my change. I think you can just replace xalloc back
> with malloc in sdram.c. Sorry.
no problem at all. s/xalloc/malloc/ in port/sdram.c fixes the issue for
my machine.
anybody else seen this?
sl
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-05-26 16:02 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-25 3:31 [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt Stanley Lieber
2023-05-25 3:33 ` Stanley Lieber
2023-05-25 4:47 ` unobe
2023-05-25 5:05 ` Stanley Lieber
2023-05-25 11:42 ` mia soweli
2023-05-25 13:51 ` Stanley Lieber
2023-05-25 15:16 ` Sigrid Solveig Haflínudóttir
2023-05-26 0:50 ` sl
2023-05-26 1:06 ` Sigrid Solveig Haflínudóttir
2023-05-26 2:00 ` sl
2023-05-26 15:36 ` Tobias Heinicke
2023-05-26 15:42 ` Jacob Moody
2023-05-26 15:56 ` Stanley Lieber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).