9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
To: ori@eigenstate.org
Cc: 9front@9front.org
Subject: Re: [9front] ape/bsd: Enable setting the local address with bind
Date: Fri, 10 Jun 2022 17:14:46 +0200	[thread overview]
Message-ID: <87bkv01rfd.fsf@turtle-trading.net> (raw)
In-Reply-To: <87bkwvydi2.fsf@turtle-trading.net> (Benjamin Riefenstahl's message of "Wed, 20 Apr 2022 17:35:01 +0200")

Hi Ori,

Benjamin Riefenstahl writes:
> I often take my time myself ;-)

Again this has taken some time, sorry. 

> I will have to create some test cases to see what works and what
> doesn't.

That's what I have done now, see
<https://git.sr.ht/~cc_benny/test-socket/tree>.

I append the results, a log from Linux as a reference, one with the
current 9front (9front-front.log) and one with my patch
(9front-patch.log).

Next for me is refining the patch.  

> Ori writes:
>> And I see no specification that describes what should be done with
>> negative ports in the sockets world, so I can only assume that this is
>> a bug.
>
> I/we should probably just make negative ports an error. 

Turns out negative ports do not occur with BSD sockets because the
numbers get filtered through 'htons' which returns 'unsigned short',
naturally.

I will drop considerations of negative ports in my patch.

Benjamin Riefenstahl writes:
>>> The documentation in the man page ip(3) for the control commands
>>> "bind" and "announce" does not mention the local address, should that
>>> be fixed, too?

I will include that in my next version. 

Thanks, benny

  reply	other threads:[~2022-06-10 15:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 20:00 Benjamin Riefenstahl
2022-01-21 14:22 ` [9front] " Benjamin Riefenstahl
2022-01-21 19:22   ` ori
2022-02-10 17:38 ` Benjamin Riefenstahl
2022-04-16 17:33 ` [9front] " ori
2022-04-20 15:35   ` Benjamin Riefenstahl
2022-06-10 15:14     ` Benjamin Riefenstahl [this message]
2022-06-10 15:16       ` Benjamin Riefenstahl
2022-06-11 17:13       ` ori
2022-06-11 18:31         ` Benjamin Riefenstahl
2022-07-07 21:22       ` Benjamin Riefenstahl
2022-07-17 19:05         ` ori
2022-07-17 22:01           ` Benjamin Riefenstahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkv01rfd.fsf@turtle-trading.net \
    --to=b.riefenstahl@turtle-trading.net \
    --cc=9front@9front.org \
    --cc=ori@eigenstate.org \
    --subject='Re: [9front] ape/bsd: Enable setting the local address with bind' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).