[PATCH 0/4] Initial Coverity fixes

[PATCH 0/4] Initial Coverity fixes

[john]

All of the issues addressed here are harmless, but it will let us see
what happens when we fix problems identified by Coverity.

I also marked a couple of problems as false positives in the interface,
but someone should double-check those.

John Keeping (4):
  cgit.c: remove useless null check
  scan-tree: remove useless strdup()
  ui-blob: remove useless null check
  ui-refs: remove useless null check

 cgit.c      |    2 +-
 scan-tree.c |    2 +-
 ui-blob.c   |    2 +-
 ui-refs.c   |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.7.9.5

[PATCH 1/4] cgit.c: remove useless null check

[john]

Everywhere else in this function we do not check whether the value is
null and parse_configfile() never passes a null value to this callback.

Coverity-id: 13846
Signed-off-by: John Keeping <john at keeping.me.uk>
---
 cgit.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cgit.c b/cgit.c
index 28a2f14..5937b9e 100644
--- a/cgit.c
+++ b/cgit.c
@@ -110,7 +110,7 @@ static void config_cb(const char *name, const char *value)
 		ctx.repo->path = trim_end(value, '/');
 	else if (ctx.repo && starts_with(name, "repo."))
 		repo_config(ctx.repo, name + 5, value);
-	else if (!strcmp(name, "readme") && value != NULL)
+	else if (!strcmp(name, "readme"))
 		string_list_append(&ctx.cfg.readme, xstrdup(value));
 	else if (!strcmp(name, "root-title"))
 		ctx.cfg.root_title = xstrdup(value);
-- 
1.7.9.5

[PATCH 2/4] scan-tree: remove useless strdup()

[john]

parse_configfile() takes a "const char *" and doesn't hold any
references to it after it returns; there is no reason to pass it a
duplicate.

Coverity-id: 13941
Signed-off-by: John Keeping <john at keeping.me.uk>
---
 scan-tree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scan-tree.c b/scan-tree.c
index 8e3cf52..b5a10ff 100644
--- a/scan-tree.c
+++ b/scan-tree.c
@@ -174,7 +174,7 @@ static void add_repo(const char *base, struct strbuf *path, repo_config_fn fn)
 
 	strbuf_addstr(path, "cgitrc");
 	if (!stat(path->buf, &st))
-		parse_configfile(xstrdup(path->buf), &repo_config);
+		parse_configfile(path->buf, &repo_config);
 
 	strbuf_release(&rel);
 }
-- 
1.7.9.5

[PATCH 3/4] ui-blob: remove useless null check

[john]

We have already called strlen() on "path" by the time we get here, so we
know it can't be null.

Coverity-id: 13954
Signed-off-by: John Keeping <john at keeping.me.uk>
---
 ui-blob.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-blob.c b/ui-blob.c
index b333f86..d3c3a10 100644
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -85,7 +85,7 @@ int cgit_print_file(char *path, const char *head, int file_only)
 	if (get_sha1(head, sha1))
 		return -1;
 	type = sha1_object_info(sha1, &size);
-	if (type == OBJ_COMMIT && path) {
+	if (type == OBJ_COMMIT) {
 		commit = lookup_commit_reference(sha1);
 		read_tree_recursive(commit->tree, "", 0, 0, &paths, walk_tree, &walk_tree_ctx);
 		if (!walk_tree_ctx.found_path)
-- 
1.7.9.5

[PATCH 4/4] ui-refs: remove useless null check

[john]

There is no way that "tag" can be null here.

Coverity-id: 13950
Signed-off-by: John Keeping <john at keeping.me.uk>
---
 ui-refs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-refs.c b/ui-refs.c
index be3572c..295a4c7 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -135,7 +135,7 @@ static int print_tag(struct refinfo *ref)
 		tag = (struct tag *)obj;
 		obj = tag->tagged;
 		info = ref->tag;
-		if (!tag || !info)
+		if (!info)
 			return 1;
 	}
 
-- 
1.7.9.5

[PATCH 0/4] Initial Coverity fixes

[Jason]

Great! Thanks. Merged. We'll see what happens.