List for cgit developers and users
 help / color / Atom feed
* [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
@ 2019-03-15 20:17 aklhfex
  2019-04-03  1:24 ` e
  2019-04-16 16:47 ` petr.vorel
  0 siblings, 2 replies; 3+ messages in thread
From: aklhfex @ 2019-03-15 20:17 UTC (permalink / raw)


The title attribute was being set to the same value as the anchor
element text.

Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
 ui-repolist.c | 2 +-
 ui-shared.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui-repolist.c b/ui-repolist.c
index 41424c0..80c85d3 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -321,7 +321,7 @@ void cgit_print_repolist(void)
 		}
 		htmlf("<tr><td class='%s'>",
 		      !sorted && section ? "sublevel-repo" : "toplevel-repo");
-		cgit_summary_link(ctx.repo->name, ctx.repo->name, NULL, NULL);
+		cgit_summary_link(ctx.repo->name, NULL, NULL, NULL);
 		html("</td><td>");
 		repourl = cgit_repourl(ctx.repo->url);
 		html_link_open(repourl, NULL, NULL);
diff --git a/ui-shared.c b/ui-shared.c
index d27a5fd..13d54af 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -992,7 +992,7 @@ static void print_header(void)
 	if (ctx.repo) {
 		cgit_index_link("index", NULL, NULL, NULL, NULL, 0, 1);
 		html(" : ");
-		cgit_summary_link(ctx.repo->name, ctx.repo->name, NULL, NULL);
+		cgit_summary_link(ctx.repo->name, NULL, NULL, NULL);
 		if (ctx.env.authenticated) {
 			html("</td><td class='form'>");
 			html("<form method='get'>\n");
-- 
2.21.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
  2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
@ 2019-04-03  1:24 ` e
  2019-04-16 16:47 ` petr.vorel
  1 sibling, 0 replies; 3+ messages in thread
From: e @ 2019-04-03  1:24 UTC (permalink / raw)


Chris Mayo <aklhfex at gmail.com> wrote:
> The title attribute was being set to the same value as the anchor
> element text.
> 
> Signed-off-by: Chris Mayo <aklhfex at gmail.com>

I am not an HTML expert; but it looks like a reasonable change to
avoid the redundant tooltip.

Acked-by: Eric Wong <e at 80x24.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
  2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
  2019-04-03  1:24 ` e
@ 2019-04-16 16:47 ` petr.vorel
  1 sibling, 0 replies; 3+ messages in thread
From: petr.vorel @ 2019-04-16 16:47 UTC (permalink / raw)


Hi,

> The title attribute was being set to the same value as the anchor
> element text.

> Signed-off-by: Chris Mayo <aklhfex at gmail.com>
Reviewed-by: Petr Vorel <petr.vorel at gmail.com>

Good idea.

Kind regards,
Petr



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
2019-04-03  1:24 ` e
2019-04-16 16:47 ` petr.vorel

List for cgit developers and users

Archives are clonable: git clone --mirror http://inbox.vuxu.org/cgit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git