From: "Samuel Lidén Borell" <samuel@kodafritt.se>
To: cgit@lists.zx2c4.com
Subject: Re: [PATCH RESEND v2] css: Support for dark mode
Date: Thu, 12 Jan 2023 01:33:05 +0100 [thread overview]
Message-ID: <20230112013305.0b5ccab36a3a81330f91f371@kodafritt.se> (raw)
In-Reply-To: <CAHmME9pn7obiCcZEPy1ryu1iz+1bYxEEN7MwcaE9tuzO+cEJ-w@mail.gmail.com>
Oops. I made a last minute change of the themes, and that broke things. Looks like some theme combinations don't work well.
I will send an updated patch with a working theme combo + a comment about this.
It could also be solved by also wrapping the light theme in a media query, but then older browsers will not show the highlighting.
Regards,
Samuel
On Wed, 11 Jan 2023 21:56:30 +0100, "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> It looks like the issue is that the string class for the light theme is:
>
> .highlight .s {
> color: #dd2200;
> background-color: #fff0f0;
> }
>
> But for the dark theme it's:
>
> @media (prefers-color-scheme: dark)
> .highlight .s {
> color: #e6db74;
> }
>
> And so it winds up using the dark color, but with the light
> background, because the dark theme doesn't specify a background.
next prev parent reply other threads:[~2023-01-12 0:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 21:15 [PATCH] css: Optional support " Samuel Lidén Borell
2023-01-02 0:51 ` Jason A. Donenfeld
2023-01-01 21:15 ` [PATCH RESEND v2] css: Support " Samuel Lidén Borell
2023-01-11 20:54 ` Jason A. Donenfeld
2023-01-11 20:56 ` Jason A. Donenfeld
2023-01-12 0:33 ` Samuel Lidén Borell [this message]
2023-01-12 0:34 ` Jason A. Donenfeld
2023-01-12 0:33 ` Jason A. Donenfeld
2023-01-22 11:35 ` [PATCH v3] " Samuel Lidén Borell
2023-01-22 13:04 ` Samuel Lidén Borell
2023-01-27 20:42 ` Jason A. Donenfeld
2023-01-29 17:07 ` Samuel Lidén Borell
2023-01-29 16:55 ` [PATCH v4] " Samuel Lidén Borell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112013305.0b5ccab36a3a81330f91f371@kodafritt.se \
--to=samuel@kodafritt.se \
--cc=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).