List for cgit developers and users
 help / color / mirror / Atom feed
From: Kian Kasad <>
Subject: Follow-up: User-configurable log graph option
Date: Thu, 05 Jan 2023 15:14:42 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20211230210820.3ncgngexbbhlpbdq@frisbee.local>

Hello cgit developers,

Just over a year ago, I proposed a configurable "graph" option for the
log page. The idea was met with positive feedback, but when I proposed
my implementation I never heard back. So I'm trying again in hopes that
I can get a response. It would be nice if this was merged into the
upstream so I don't have to maintain my fork, but if the way I've
chosen to go about it isn't desirable, then I understand. But even in
the latter case, I need a "no" so I know to stop trying to push this.

The original conversation is below. I've also finished the
implementation and am using it at if you'd like
to test it out.

See here for my fork of cgit implementing this change:

On Thu, 2021-12-30 at 13:08 -0800, Kian Kasad wrote:
> On 21/02/19 12:22PM, John Keeping wrote:
> > On Thu, Feb 18, 2021 at 02:31:26PM -0800, Kian Kasad wrote:
> > > I'm using cgit on my website and I'm wondering if it's possible
> > > to allow
> > > the user (i.e. the person visiting the site) to choose whether or
> > > not
> > > the commit graph is displayed on the log page.
> > > 
> > > If this isn't currently possible, what do you think about adding
> > > such
> > > functionality? Maybe something like how the diff page lets the
> > > user
> > > choose between a "unified diff" and "ssdiff".
> > 
> > This sounds like a great new feature!
> > 
> > I think we still want to allow the administrator to turn the
> > feature
> > on/off but if it is permitted, then it makes sense to allow the end
> > user
> > to choose whether or not they want it enabled.
> Following up on this as I'm finally getting around to implementing
> this
> feature. I'm not too familiar with CGit's codebase, so I think it
> would
> be easier to implement this as a separate "graph" page which is
> identical to the log page except that it always displays a graph.
> This graph page would only be shown in the navbar's tab list if the
> "enable-commit-graph" option is set to "separate" in the
> configuration.
> If it is set to "combined" then the graph page will be disabled and
> the
> commit graph will be displayed on the log page as it currently is
> when
> the "enable-commit-graph" option is set to "1".
> In order to maintain backwards compatibility, the value "1" could
> also
> be interpreted as the value "combined" since it has the same
> functionality currently.
> The value "none" (or "0" for backwards compatibility) would disable
> the
> graph page as well as disabling the commit graph on the log page.
> I've already started working on this as I want it for my own CGit
> site.
> If this is something that the maintainer(s) want to integrate, I'll
> send
> patches when I'm done.

Kian Kasad
(925) 871-9823

  parent reply	other threads:[~2023-01-05 23:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 22:31 Kian Kasad
2021-02-19 12:22 ` John Keeping
2021-12-30 21:08   ` Kian Kasad
2022-08-05  4:59     ` [PATCH 0/6] Option for separate 'log' and 'graph' pages Kian Kasad
2022-08-05  4:59       ` [PATCH 1/6] Implement parsing of new enable-commit-graph option Kian Kasad
2022-08-05  4:59       ` [PATCH 2/6] Add graph page Kian Kasad
2022-08-05  4:59       ` [PATCH 3/6] Don't display commit age on " Kian Kasad
2022-08-05  4:59       ` [PATCH 4/6] Don't display graph page if enable-commit-graph is not set to "separate" Kian Kasad
2022-08-05  4:59       ` [PATCH 5/6] Add graph page tab if enable-commit-graph is " Kian Kasad
2022-08-05  4:59       ` [PATCH 6/6] Document new enable-commit-graph option Kian Kasad
2023-01-05 23:14     ` Kian Kasad [this message]
2023-07-01  6:28       ` Follow-up: User-configurable log graph option Daniel Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).