List for cgit developers and users
 help / color / mirror / Atom feed
* Use ellipsis in /log
@ 2019-05-05  9:49 
  0 siblings, 0 replies; 2+ messages in thread
From:  @ 2019-05-05  9:49 UTC (permalink / raw)


Hello,

I propose using ? instead of ... in the /repo/log output.

Regards
  ?????

diff --git a/ui-shared.c b/ui-shared.c
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -435,8 +435,8 @@ void cgit_commit_link(const char *name, const char *title, const char *class,
        html("'>");
        if (name[0] != '\0') {
                if (strlen(name) > ctx.cfg.max_msg_len && ctx.cfg.max_msg_len >= 15) {
-                       html_ntxt(name, ctx.cfg.max_msg_len - 3);
-                       html("...");
+                       html_ntxt(name, ctx.cfg.max_msg_len - 1);
+                       html("…");
                } else
                        html_txt(name);
        } else



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Use ellipsis in /log
@ 2019-05-19 17:51 
  0 siblings, 0 replies; 2+ messages in thread
From:  @ 2019-05-19 17:51 UTC (permalink / raw)


This should be a response to an earlier message from ????? ????????,
however I don't have the message to respond to.

---

I agree with the intent of your patch, but not the implementation. Instead
of using the Unicode character ? and thus depending on the C source file
encoding as well as the HTML encoding, I suggest using the HTML
entity …
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20190519/7a7c0d3b/attachment.html>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-19 17:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05  9:49 Use ellipsis in /log 
2019-05-19 17:51 

List for cgit developers and users

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/cgit

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 cgit cgit/ http://inbox.vuxu.org/cgit \
		cgit@lists.zx2c4.com
	public-inbox-index cgit

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git