List for cgit developers and users
 help / color / mirror / Atom feed
From: chris.burroughs at gmail.com (Chris Burroughs)
Subject: commit-filter not being applied on log page
Date: Fri, 01 Aug 2014 14:06:11 -0400	[thread overview]
Message-ID: <53DBD713.6030709@gmail.com> (raw)
In-Reply-To: <20140801094429.GP26927@serenity.lan>

On 08/01/2014 05:44 AM, John Keeping wrote:
> On Thu, Jul 31, 2014 at 10:27:19AM -0400, Chris Burroughs wrote:
>> I'm trying to write a commit-filter to hyperlink references to our bug
>> tracker.  It seems to work fine for commit detailed pages, but not at
>> all for the log view.  Since our developers often make brief messages
>> like "fixes #123' so getting the url in the log view is arguably more
>> useful than in the detail page.
>
> I think this is an issue of the cost of forking a filter process for
> each line in the log view.  Now that we have Lua filters that may not be
> so much of an issue, but I don't think we can just start using the
> source filter on the log view due to the impact that will have on people
> with an "exec" source-filter already configured.
>
> Perhaps we need to add a "log-filter" which you could configure to be
> the same as "source-filter" but which can be left blank for people whose
> links are normally in the body of the commit message.
>

I think a "log-filter" with the same API sounds good and fits my use 
case.  I'll take a stab at that after the owner-filter work.


  reply	other threads:[~2014-08-01 18:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 14:27 chris.burroughs
2014-08-01  9:44 ` john
2014-08-01 18:06   ` chris.burroughs [this message]
2014-12-24  2:03     ` Jason
2015-01-05 19:03   ` chris.burroughs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DBD713.6030709@gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).